<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25259">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/octopus: Do not configure GPIO_149 as GPO<br><br>GPIO_149 is used as ESPI clock feedback and configuring it as a GPO<br>results in EC communication failure. This change removes the<br>configuration of GPIO_149 as GPO in ramstage so that it remains<br>configured for ESPI (as it was when AP came out of reset).<br><br>BUG=b:75348718<br><br>Change-Id: Ie4f21b12fae027cdba54ce147e6d1a88ee854792<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/octopus/variants/baseboard/gpio.c<br>1 file changed, 0 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/25259/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c</span><br><span>index d06de1a..135fab9 100644</span><br><span>--- a/src/mainboard/google/octopus/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c</span><br><span>@@ -207,7 +207,6 @@</span><br><span>   PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_144, NONE, DEEP, NF5, HIZCRx0, DISPUPD),/* PANEL1_VDDN */</span><br><span>   PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_145, NONE, DEEP, NF5, HIZCRx0, DISPUPD),/* PANEL1_BKLTEN */</span><br><span>         PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_146, NONE, DEEP, NF5, HIZCRx0, DISPUPD),/* PANEL1_BKLTCTL */</span><br><span style="color: hsl(0, 100%, 40%);">-   PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_149, 1, DEEP, NONE, HIZCRx1, DISPUPD),/* LPC_CLKOUT1 -- EN_PP3300_WLAN */</span><br><span>  PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_154, 1, DEEP, UP_20K, HIZCRx1, DISPUPD),/* LPC_CLKRUNB -- LTE_OFF_ODL */</span><br><span> </span><br><span>       /* AUDIO COMMUNITY GPIOS*/</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25259">change 25259</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25259"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie4f21b12fae027cdba54ce147e6d1a88ee854792 </div>
<div style="display:none"> Gerrit-Change-Number: 25259 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>