<p>Kin Wai Ng would like Naresh Solanki, Subrata Banik, Balaji Manigandan, Aamir Bohra, Maulik V Vaghela and Rizwan Qureshi to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/25230">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/intel/coffeelake_rvp: Modified memory dimm settings<br><br>Change-Id: I9bf2897fcafe63bfe32678a4d49d88b08f5d35bf<br>Signed-off-by: Ng Kin Wai <kin.wai.ng@intel.com><br>---<br>M src/mainboard/intel/coffeelake_rvp/romstage.c<br>M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb<br>2 files changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/25230/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/intel/coffeelake_rvp/romstage.c b/src/mainboard/intel/coffeelake_rvp/romstage.c</span><br><span>index a2c719b..eba02ef 100755</span><br><span>--- a/src/mainboard/intel/coffeelake_rvp/romstage.c</span><br><span>+++ b/src/mainboard/intel/coffeelake_rvp/romstage.c</span><br><span>@@ -39,6 +39,12 @@</span><br><span>    mem_cfg->DqPinsInterleaved = 1;</span><br><span>   mem_cfg->CaVrefConfig = 2; /* VREF_CA->CHA/CHB */</span><br><span>      mem_cfg->ECT = 1; /* Early Command Training Enabled */</span><br><span style="color: hsl(120, 100%, 40%);">+     mem_cfg->SafeMode = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     mem_cfg->RaplLim1WindX = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+        mem_cfg->RaplLim1WindY = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+        mem_cfg->RaplLim1Pwr = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+  mem_cfg->RhPrevention = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      spd_index = 2;</span><br><span> </span><br><span>   struct region_device spd_rdev;</span><br><span>diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb</span><br><span>index 3867ff9..0a18432 100755</span><br><span>--- a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb</span><br><span>+++ b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb</span><br><span>@@ -6,6 +6,7 @@</span><br><span> </span><br><span>        # FSP configuration</span><br><span>  register "SaGv" = "3"</span><br><span style="color: hsl(120, 100%, 40%);">+     register "RMT" = "1"</span><br><span>     register "FspSkipMpInit" = "0"</span><br><span>   register "SmbusEnable" = "1"</span><br><span>     register "ScsEmmcEnabled" = "1"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25230">change 25230</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25230"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9bf2897fcafe63bfe32678a4d49d88b08f5d35bf </div>
<div style="display:none"> Gerrit-Change-Number: 25230 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kin Wai Ng <kin.wai.ng@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>