<p>Kin Wai Ng would like Naresh Solanki, Subrata Banik, Balaji Manigandan, Aamir Bohra, Maulik V Vaghela and Rizwan Qureshi to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/25244">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/intel/coffeelake_rvp: Remove unused i2c devices<br><br>Change-Id: I80101506f607a6200f0db7edbc3c7196f5da92ba<br>Signed-off-by: Ng Kin Wai <kin.wai.ng@intel.com><br>---<br>M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb<br>1 file changed, 3 insertions(+), 29 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/25244/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb</span><br><span>index c752258..571d61b 100755</span><br><span>--- a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb</span><br><span>+++ b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb</span><br><span>@@ -106,36 +106,10 @@</span><br><span>              device pci 14.1 off end # USB xDCI (OTG)</span><br><span>             device pci 14.3 on  end # CNVi wifi</span><br><span>          device pci 14.5 on  end # SDCard</span><br><span style="color: hsl(0, 100%, 40%);">-                device pci 15.0 on</span><br><span style="color: hsl(0, 100%, 40%);">-                      chip drivers/i2c/hid</span><br><span style="color: hsl(0, 100%, 40%);">-                            register "generic.hid" = ""ALPS0001""</span><br><span style="color: hsl(0, 100%, 40%);">-                             register "generic.desc" = ""Touchpad""</span><br><span style="color: hsl(0, 100%, 40%);">-                            register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"</span><br><span style="color: hsl(0, 100%, 40%);">-                           register "hid_desc_reg_offset" = "0x1"</span><br><span style="color: hsl(0, 100%, 40%);">-                              device i2c 2C on end</span><br><span style="color: hsl(0, 100%, 40%);">-                    end</span><br><span style="color: hsl(0, 100%, 40%);">-             end # I2C 0</span><br><span style="color: hsl(120, 100%, 40%);">+           device pci 15.0 on  end # I2C 0</span><br><span>              device pci 15.1 on  end # I2C #1</span><br><span style="color: hsl(0, 100%, 40%);">-                device pci 15.2 off end # I2C #2</span><br><span style="color: hsl(0, 100%, 40%);">-                device pci 15.3 on</span><br><span style="color: hsl(0, 100%, 40%);">-                      chip drivers/i2c/da7219</span><br><span style="color: hsl(0, 100%, 40%);">-                         register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A20)"</span><br><span style="color: hsl(0, 100%, 40%);">-                              register "btn_cfg" = "50"</span><br><span style="color: hsl(0, 100%, 40%);">-                           register "mic_det_thr" = "500"</span><br><span style="color: hsl(0, 100%, 40%);">-                              register "jack_ins_deb" = "20"</span><br><span style="color: hsl(0, 100%, 40%);">-                              register "jack_det_rate" = ""32ms_64ms""</span><br><span style="color: hsl(0, 100%, 40%);">-                          register "jack_rem_deb" = "1"</span><br><span style="color: hsl(0, 100%, 40%);">-                               register "a_d_btn_thr" = "0xa"</span><br><span style="color: hsl(0, 100%, 40%);">-                              register "d_b_btn_thr" = "0x16"</span><br><span style="color: hsl(0, 100%, 40%);">-                             register "b_c_btn_thr" = "0x21"</span><br><span style="color: hsl(0, 100%, 40%);">-                             register "c_mic_btn_thr" = "0x3e"</span><br><span style="color: hsl(0, 100%, 40%);">-                           register "btn_avg" = "4"</span><br><span style="color: hsl(0, 100%, 40%);">-                            register "adc_1bit_rpt" = "1"</span><br><span style="color: hsl(0, 100%, 40%);">-                               register "micbias_lvl" = "2600"</span><br><span style="color: hsl(0, 100%, 40%);">-                             register "mic_amp_in_sel" = ""diff""</span><br><span style="color: hsl(0, 100%, 40%);">-                              device i2c 1a on end</span><br><span style="color: hsl(0, 100%, 40%);">-                    end</span><br><span style="color: hsl(0, 100%, 40%);">-             end   # I2C #3</span><br><span style="color: hsl(120, 100%, 40%);">+                device pci 15.2 on  end # I2C #2</span><br><span style="color: hsl(120, 100%, 40%);">+              device pci 15.3 on  end # I2C #3</span><br><span>             device pci 16.0 on  end # Management Engine Interface 1</span><br><span>              device pci 16.1 off end # Management Engine Interface 2</span><br><span>              device pci 16.2 off end # Management Engine IDE-R</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25244">change 25244</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25244"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I80101506f607a6200f0db7edbc3c7196f5da92ba </div>
<div style="display:none"> Gerrit-Change-Number: 25244 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kin Wai Ng <kin.wai.ng@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Naresh Solanki <naresh.solanki@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> </div>