<p>Philipp Deppenwiese has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25196">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">security/flash: Add SPI flash protection<br><br>* get/set write protection for SPI flash.<br>* GPIO weak function for WP pin lookup (VBOOT).<br><br>Change-Id: I12656d7c111ed3622fab5578f6e0c462fe5d4796<br>Signed-off-by: zaolin <zaolin@das-labor.org><br>---<br>M src/security/Kconfig<br>M src/security/Makefile.inc<br>A src/security/flash/Kconfig<br>A src/security/flash/Makefile.inc<br>A src/security/flash/flash.c<br>A src/security/flash/flash.h<br>6 files changed, 229 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/25196/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/security/Kconfig b/src/security/Kconfig</span><br><span>index 6a334ac..006d089 100644</span><br><span>--- a/src/security/Kconfig</span><br><span>+++ b/src/security/Kconfig</span><br><span>@@ -14,3 +14,4 @@</span><br><span> </span><br><span> source "src/security/vboot/Kconfig"</span><br><span> source "src/security/tpm/Kconfig"</span><br><span style="color: hsl(120, 100%, 40%);">+source "src/security/flash/Kconfig"</span><br><span>diff --git a/src/security/Makefile.inc b/src/security/Makefile.inc</span><br><span>index a940b82..413f7d0 100644</span><br><span>--- a/src/security/Makefile.inc</span><br><span>+++ b/src/security/Makefile.inc</span><br><span>@@ -1,2 +1,3 @@</span><br><span> subdirs-y += vboot</span><br><span> subdirs-y += tpm</span><br><span style="color: hsl(120, 100%, 40%);">+subdirs-y += flash</span><br><span>diff --git a/src/security/flash/Kconfig b/src/security/flash/Kconfig</span><br><span>new file mode 100644</span><br><span>index 0000000..67e62c7</span><br><span>--- /dev/null</span><br><span>+++ b/src/security/flash/Kconfig</span><br><span>@@ -0,0 +1,102 @@</span><br><span style="color: hsl(120, 100%, 40%);">+## This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+##</span><br><span style="color: hsl(120, 100%, 40%);">+## Copyright (C) 2017 Philipp Deppenwiese, Facebook, Inc.</span><br><span style="color: hsl(120, 100%, 40%);">+##</span><br><span style="color: hsl(120, 100%, 40%);">+## This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+## it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+## the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+##</span><br><span style="color: hsl(120, 100%, 40%);">+## This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+## but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+## GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+##</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+menu "Flash write protection"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config FLASH_SPI_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+ default y if MAINBOARD_HAS_FLASH_SPI_PROTECTIONS || USER_FLASH_SPI_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+ depends on SPI_FLASH</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config FLASH_PCH_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+ default y if MAINBOARD_HAS_FLASH_PCH_PROTECTIONS || USER_FLASH_PCH_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config MAINBOARD_HAS_FLASH_PCH_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config MAINBOARD_HAS_FLASH_SPI_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+if !MAINBOARD_HAS_FLASH_SPI_PROTECTIONS && !MAINBOARD_HAS_FLASH_PCH_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+choice</span><br><span style="color: hsl(120, 100%, 40%);">+ prompt "Type"</span><br><span style="color: hsl(120, 100%, 40%);">+ default USER_FLASH_PCH_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config USER_FLASH_SPI_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "SPI flash"</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ Enable this option to enable SPI flash write protection.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config USER_FLASH_PCH_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "Platform PCH"</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ Enable this option to enable PCH flash write protection.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+endchoice</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config FLASH_MODE_VBOOT</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+ default y if MAINBOARD_HAS_FLASH_MODE_VBOOT || USER_FLASH_SPI_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+ depends on VBOOT</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config FLASH_MODE_BIOS</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+ default y if MAINBOARD_HAS_FLASH_MODE_BIOS || USER_FLASH_PCH_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config FLASH_MODE_EVERYTHING</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+ default y if MAINBOARD_HAS_FLASH_MODE_EVERYTHING || USER_FLASH_PCH_PROTECTIONS</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config MAINBOARD_HAS_FLASH_MODE_VBOOT</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config MAINBOARD_HAS_FLASH_MODE_BIOS</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config MAINBOARD_HAS_FLASH_MODE_EVERYTHING</span><br><span style="color: hsl(120, 100%, 40%);">+ bool</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+if !MAINBOARD_HAS_FLASH_MODE_VBOOT && !MAINBOARD_HAS_FLASH_MODE_BIOS && !MAINBOARD_HAS_FLASH_MODE_EVERYTHING</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+choice</span><br><span style="color: hsl(120, 100%, 40%);">+ prompt "Mode"</span><br><span style="color: hsl(120, 100%, 40%);">+ default USER_NO_FLASH_PROTECTION</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config USER_NO_FLASH_PROTECTION</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "disabled"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config USER_FLASH_MODE_VBOOT</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "Verified Boot"</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ Enable this option to enable VBoot mode.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config USER_FLASH_MODE_BIOS</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "BIOS region"</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ Enable this option to enable BIOS region write protection.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config USER_FLASH_MODE_EVERYTHING</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "Entire SPI flash"</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ Enable this option to enable entire flash write protection.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+endchoice</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+endmenu</span><br><span>diff --git a/src/security/flash/Makefile.inc b/src/security/flash/Makefile.inc</span><br><span>new file mode 100644</span><br><span>index 0000000..50d4a7a</span><br><span>--- /dev/null</span><br><span>+++ b/src/security/flash/Makefile.inc</span><br><span>@@ -0,0 +1,5 @@</span><br><span style="color: hsl(120, 100%, 40%);">+## flash</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+verstage-y += flash.c</span><br><span style="color: hsl(120, 100%, 40%);">+romstage-y += flash.c</span><br><span style="color: hsl(120, 100%, 40%);">+ramstage-y += flash.c</span><br><span>diff --git a/src/security/flash/flash.c b/src/security/flash/flash.c</span><br><span>new file mode 100644</span><br><span>index 0000000..b103909</span><br><span>--- /dev/null</span><br><span>+++ b/src/security/flash/flash.c</span><br><span>@@ -0,0 +1,96 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Facebook Inc.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <commonlib/region.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <fmap.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <security/flash/flash.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <spi_flash.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define FMAP_VBOOT_RO_REGION "WP_RO"</span><br><span style="color: hsl(120, 100%, 40%);">+#define FMAP_BIOS_REGION "BIOS"</span><br><span style="color: hsl(120, 100%, 40%);">+#define FMAP_FLASH_REGION "FLASH"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+__attribute__((weak)) int gpio_get_wp_state(void) { return 0; }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int set_write_protect_enabled(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int result = -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct region region;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (IS_ENABLED(CONFIG_FLASH_SPI_PROTECTIONS)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct spi_flash flash;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ spi_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ if (spi_flash_probe(0, 0, &flash))</span><br><span style="color: hsl(120, 100%, 40%);">+ return result;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (IS_ENABLED(CONFIG_FLASH_MODE_VBOOT)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fmap_locate_area(FMAP_VBOOT_RO_REGION, ®ion) ==</span><br><span style="color: hsl(120, 100%, 40%);">+ 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ result = spi_flash_set_write_protected(&flash,</span><br><span style="color: hsl(120, 100%, 40%);">+ ®ion);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (IS_ENABLED(CONFIG_FLASH_MODE_BIOS)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fmap_locate_area(FMAP_BIOS_REGION, ®ion) == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ result = spi_flash_set_write_protected(&flash,</span><br><span style="color: hsl(120, 100%, 40%);">+ ®ion);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (IS_ENABLED(CONFIG_FLASH_MODE_EVERYTHING)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fmap_locate_area(FMAP_FLASH_REGION, ®ion) == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ result = spi_flash_set_write_protected(&flash,</span><br><span style="color: hsl(120, 100%, 40%);">+ ®ion);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (IS_ENABLED(CONFIG_FLASH_PCH_PROTECTIONS)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return result;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int get_write_protect_state(void)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int result = -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct region region;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (IS_ENABLED(CONFIG_FLASH_SPI_PROTECTIONS)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct spi_flash flash;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ spi_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ if (spi_flash_probe(0, 0, &flash))</span><br><span style="color: hsl(120, 100%, 40%);">+ return result;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (IS_ENABLED(CONFIG_FLASH_MODE_VBOOT)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fmap_locate_area(FMAP_VBOOT_RO_REGION, ®ion) ==</span><br><span style="color: hsl(120, 100%, 40%);">+ 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ result = spi_flash_is_write_protected(&flash,</span><br><span style="color: hsl(120, 100%, 40%);">+ ®ion);</span><br><span style="color: hsl(120, 100%, 40%);">+ result &= gpio_get_wp_state();</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (IS_ENABLED(CONFIG_FLASH_MODE_BIOS)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fmap_locate_area(FMAP_BIOS_REGION, ®ion) == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ result = spi_flash_is_write_protected(&flash,</span><br><span style="color: hsl(120, 100%, 40%);">+ ®ion);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (IS_ENABLED(CONFIG_FLASH_MODE_EVERYTHING)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (fmap_locate_area(FMAP_FLASH_REGION, ®ion) == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ result = spi_flash_is_write_protected(&flash,</span><br><span style="color: hsl(120, 100%, 40%);">+ ®ion);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (IS_ENABLED(CONFIG_FLASH_PCH_PROTECTIONS)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return result;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/security/flash/flash.h b/src/security/flash/flash.h</span><br><span>new file mode 100644</span><br><span>index 0000000..bbd60df</span><br><span>--- /dev/null</span><br><span>+++ b/src/security/flash/flash.h</span><br><span>@@ -0,0 +1,24 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2018 Facebook Inc.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef FLASH_H_</span><br><span style="color: hsl(120, 100%, 40%);">+#define FLASH_H_</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int gpio_get_wp_state(void);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int set_write_protect_enabled(void);</span><br><span style="color: hsl(120, 100%, 40%);">+int get_write_protect_state(void);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#endif /* FLASH_H_ */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25196">change 25196</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25196"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I12656d7c111ed3622fab5578f6e0c462fe5d4796 </div>
<div style="display:none"> Gerrit-Change-Number: 25196 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>