<p>Shelley Chen has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25162">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nami: Add gpio-keys ACPI node for PENH<br><br>Use gpio_keys driver to add ACPI node for pen eject event.  Also<br>setting gpio wake pin for wake events.<br><br>BUG=b:73121017<br>BRANCH=None<br>TEST=./util/abuild/abuild -p none -t google/poppy -x -a<br><br>Change-Id: I5d87d938ac3a4e52e676850b9d8b80e83726275d<br>Signed-off-by: Shelley Chen <shchen@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/nami/devicetree.cb<br>M src/mainboard/google/poppy/variants/nami/gpio.c<br>2 files changed, 13 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/25162/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>index 602e41b..913d29e 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>@@ -282,6 +282,15 @@</span><br><span>                                 register "hid_desc_reg_offset" = "0x1"</span><br><span>                                 device i2c 0x9 on end</span><br><span>                         end</span><br><span style="color: hsl(120, 100%, 40%);">+                      chip drivers/generic/gpio_keys</span><br><span style="color: hsl(120, 100%, 40%);">+                                register "name" = ""PENH""</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_E8)"</span><br><span style="color: hsl(120, 100%, 40%);">+                            register "key.dev_name" = ""EJCT""</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "key.linux_code" = "SW_PEN_INSERTED"</span><br><span style="color: hsl(120, 100%, 40%);">+                             register "key.linux_input_type" = "EV_SW"</span><br><span style="color: hsl(120, 100%, 40%);">+                         register "key.label" = ""pen_eject""</span><br><span style="color: hsl(120, 100%, 40%);">+                            device generic 0 on end</span><br><span style="color: hsl(120, 100%, 40%);">+                       end</span><br><span>          end # I2C #2</span><br><span>                 device pci 15.3 on</span><br><span>                   chip drivers/generic/max98357a</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>index 8337e72..01204e7 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>@@ -211,8 +211,8 @@</span><br><span> </span><br><span>    /* E0  : SATAXPCI0 ==> H1_PCH_INT_ODL */</span><br><span>  PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST),</span><br><span style="color: hsl(0, 100%, 40%);">-  /* E1  : SATAXPCIE1 ==> SATA_GP1 */</span><br><span style="color: hsl(0, 100%, 40%);">-  PAD_CFG_NF(GPP_E1, NONE, DEEP, NF1),</span><br><span style="color: hsl(120, 100%, 40%);">+  /* E1  : SATAXPCIE1 ==> PEN_EJECT_ODL - for wake event */</span><br><span style="color: hsl(120, 100%, 40%);">+  PAD_CFG_GPI_GPIO_DRIVER(GPP_E1, NONE, DEEP),</span><br><span>         /* E2  : SATAXPCIE2 ==> NC(TP916) */</span><br><span>      PAD_CFG_NC(GPP_E2),</span><br><span>  /* E3  : CPU_GP0 ==> TRACKPAD_INT# */</span><br><span>@@ -225,8 +225,8 @@</span><br><span>       PAD_CFG_NC(GPP_E6),</span><br><span>  /* E7  : CPU_GP1 ==> TOUCHSCREEN_INT# */</span><br><span>  PAD_CFG_GPI_APIC(GPP_E7, NONE, PLTRST),</span><br><span style="color: hsl(0, 100%, 40%);">- /* E8  : SATALED# ==> NC */</span><br><span style="color: hsl(0, 100%, 40%);">-  PAD_CFG_NC(GPP_E8),</span><br><span style="color: hsl(120, 100%, 40%);">+   /* E8  : SATALED# ==> PEN_EJECT_ODL - for notification */</span><br><span style="color: hsl(120, 100%, 40%);">+  PAD_CFG_GPI_ACPI_SCI(GPP_E8, NONE, DEEP, NONE),</span><br><span>      /* E9  : USB2_OCO# ==> USB_C0_OC# */</span><br><span>      PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1),</span><br><span>         /* E10 : USB2_OC1# ==> USB_C1_OC# */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25162">change 25162</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25162"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5d87d938ac3a4e52e676850b9d8b80e83726275d </div>
<div style="display:none"> Gerrit-Change-Number: 25162 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Shelley Chen <shchen@google.com> </div>