<p>Nicolas Boichat has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25147">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/baseboard: Add gpio-keys ACPI node for PENH<br><br>This change uses gpio_keys driver to add ACPI node for pen eject event.<br><br>BUG=b:74413116<br>TEST=Verified using evtest that pen eject event results in events as<br>     expected.<br><br>Change-Id: I6019d633f4337137bb9fbba770040cb5b30da773<br>Signed-off-by: Nicolas Boichat <drinkcat@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/baseboard/devicetree.cb<br>M src/mainboard/google/poppy/variants/baseboard/gpio.c<br>2 files changed, 10 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/25147/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb</span><br><span>index 1027dda..074e8a2 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/devicetree.cb</span><br><span>@@ -318,6 +318,15 @@</span><br><span>                          register "hid_desc_reg_offset" = "0x1"</span><br><span>                           device i2c 0x9 on end</span><br><span>                        end</span><br><span style="color: hsl(120, 100%, 40%);">+                   chip drivers/generic/gpio_keys</span><br><span style="color: hsl(120, 100%, 40%);">+                                register "name" = ""PENH""</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_D8)"</span><br><span style="color: hsl(120, 100%, 40%);">+                            register "key.dev_name" = ""EJCT""</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "key.linux_code" = "SW_PEN_INSERTED"</span><br><span style="color: hsl(120, 100%, 40%);">+                             register "key.linux_input_type" = "EV_SW"</span><br><span style="color: hsl(120, 100%, 40%);">+                         register "key.label" = ""pen_eject""</span><br><span style="color: hsl(120, 100%, 40%);">+                            device generic 0 on end</span><br><span style="color: hsl(120, 100%, 40%);">+                       end</span><br><span>          end # I2C #3</span><br><span>                 device pci 16.0 on  end # Management Engine Interface 1</span><br><span>              device pci 16.1 off end # Management Engine Interface 2</span><br><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>index 1290d18..daa9004 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>@@ -177,7 +177,7 @@</span><br><span>   /* D7  : ISH_I2C1_SDA ==> NC */</span><br><span>   PAD_CFG_NC(GPP_D7),</span><br><span>  /* D8  : ISH_I2C1_SCL ==> PEN_EJECT_ODL -- for notification */</span><br><span style="color: hsl(0, 100%, 40%);">-       PAD_CFG_GPI(GPP_D8, 20K_PU, PLTRST),</span><br><span style="color: hsl(120, 100%, 40%);">+  PAD_CFG_GPI_GPIO_DRIVER(GPP_D8, 20K_PU, DEEP),</span><br><span>       /* D9  : ISH_SPI_CS# ==> HP_IRQ_GPIO */</span><br><span>   PAD_CFG_GPI_GPIO_DRIVER(GPP_D9, NONE, PLTRST),</span><br><span>       /* D10 : ISH_SPI_CLK ==> SPKR_RST_L */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25147">change 25147</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25147"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6019d633f4337137bb9fbba770040cb5b30da773 </div>
<div style="display:none"> Gerrit-Change-Number: 25147 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nicolas Boichat <drinkcat@chromium.org> </div>