<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25145">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/inteltool: Report Skylake GPIOs as clumsy coreboot macros<br><br>Change-Id: Id8895f5d76ba2984fbda757fc00a42ac0ae852d4<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M util/inteltool/gpio_groups.c<br>1 file changed, 149 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/25145/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/inteltool/gpio_groups.c b/util/inteltool/gpio_groups.c</span><br><span>index 3937507..6d9cd6d 100644</span><br><span>--- a/util/inteltool/gpio_groups.c</span><br><span>+++ b/util/inteltool/gpio_groups.c</span><br><span>@@ -510,6 +510,148 @@</span><br><span> return "RESERVED";</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static const char *decode_table_gpio_term(const size_t term)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (term) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0: return "NONE";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 2: return "5K_PD";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 4: return "20K_PD";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 9: return "1K_PU";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 10: return "5K_PU";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 11: return "2K_PU";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 12: return "20K_PU";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 13: return "667_PU";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 15: return "NATIVE";</span><br><span style="color: hsl(120, 100%, 40%);">+ default: return "UNSUPPORTED";</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static const char *decode_table_gpio_reset(const size_t reset)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (reset) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0: return "DSW_PWROK";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 1: return "DEEP";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 2: return "PLTRST";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 3: return "RSMRST";</span><br><span style="color: hsl(120, 100%, 40%);">+ default: return "UNSUPPORTED";</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static const char *decode_table_gpio_nf(const size_t pad_mode)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (pad_mode) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0: return "GPIO";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 1: return "NF1";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 2: return "NF2";</span><br><span style="color: hsl(120, 100%, 40%);">+ case 3: return "NF3";</span><br><span style="color: hsl(120, 100%, 40%);">+ default: return "UNSUPPORTED";</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static int print_table_gpio(const struct gpio_group *const group,</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t pad,</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint32_t dw0, const uint32_t dw1)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 3032 */</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t tx_state = dw0 >> 0 & 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t tx_disable = dw0 >> 8 & 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t rx_disable = dw0 >> 9 & 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t pad_mode = dw0 >> 10 & 7;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t int_route = dw0 >> 17 & 0x0f;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t rx_invert = dw0 >> 23 & 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t rx_evcfg = dw0 >> 25 & 3;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t rx_raw1 = dw0 >> 28 & 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t rx_padsel = dw0 >> 29 & 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t pad_reset = dw0 >> 30 & 3;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t term = dw1 >> 10 & 0x0f;</span><br><span style="color: hsl(120, 100%, 40%);">+ const size_t pad_tol = dw1 >> 25 & 0x01;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *const pad_name = group->pad_names[pad * group->func_count];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rx_padsel || rx_raw1)</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pad_mode) {</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PAD_CFG_NF%s(%s, %s, %s, %s),\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ pad_tol ? "_1V8" : "", pad_name,</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_term(term),</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_reset(pad_reset),</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_nf(pad_mode));</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (!tx_disable) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!rx_disable) {</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "WARNING: %s has both TX and RX enabled"</span><br><span style="color: hsl(120, 100%, 40%);">+ ", disabling RX!\n", pad_name);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (term) {</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PAD_CFG_TERM_GPO(%s, %zu, %s, %s),\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ pad_name, tx_state,</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_term(term),</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_reset(pad_reset));</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PAD_CFG_GPO(%s, %zu, %s),\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ pad_name, tx_state,</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_reset(pad_reset));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (!rx_disable && tx_disable) {</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (int_route) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0x0:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rx_invert || rx_evcfg > 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PAD_CFG_GPI%s(%s, %s, %s%s),\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ rx_evcfg ? "_INT" : "",</span><br><span style="color: hsl(120, 100%, 40%);">+ pad_name,</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_term(term),</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_reset(pad_reset),</span><br><span style="color: hsl(120, 100%, 40%);">+ rx_evcfg ? ", EDGE" : "");</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0x1:</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0x2:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rx_evcfg == 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PAD_CFG_GPI_ACPI_SMI"</span><br><span style="color: hsl(120, 100%, 40%);">+ "(%s, %s, %s, %s),\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ pad_name,</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_term(term),</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_reset(pad_reset),</span><br><span style="color: hsl(120, 100%, 40%);">+ rx_invert ? "YES" : "NO");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0x4:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rx_evcfg > 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PAD_CFG_GPI_ACPI_SCI%s(%s, %s, %s, %s),\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ rx_evcfg ? "" : "_LEVEL", pad_name,</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_term(term),</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_reset(pad_reset),</span><br><span style="color: hsl(120, 100%, 40%);">+ rx_invert ? "YES" : "NO");</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0x8:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rx_evcfg > 1 || (rx_evcfg == 1 && rx_invert))</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PAD_CFG_GPI_APIC%s(%s, %s, %s),\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ rx_evcfg ? "_EDGE" : rx_invert ? "_INVERT" : "",</span><br><span style="color: hsl(120, 100%, 40%);">+ pad_name,</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_term(term),</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_reset(pad_reset));</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (term) {</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("_PAD_CFG(%s, %s, %s),\n", pad_name,</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_table_gpio_term(term),</span><br><span style="color: hsl(120, 100%, 40%);">+ "_DW0_VALS(DEEP, RAW, NO, LEVEL, NO, NO, "</span><br><span style="color: hsl(120, 100%, 40%);">+ "NO, NO, NO, NO, GPIO, YES, YES)");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PAD_CFG_NC(%s),\n", pad_name);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void print_gpio_group(const uint8_t pid, size_t pad_cfg,</span><br><span> const struct gpio_group *const group)</span><br><span> {</span><br><span>@@ -521,10 +663,13 @@</span><br><span> const uint32_t dw0 = read_pcr32(pid, pad_cfg);</span><br><span> const uint32_t dw1 = read_pcr32(pid, pad_cfg + 4);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- printf("0x%04zx: 0x%016"PRIx64" %-8s %-20s\n", pad_cfg,</span><br><span style="color: hsl(0, 100%, 40%);">- (uint64_t)dw1 << 32 | dw0,</span><br><span style="color: hsl(0, 100%, 40%);">- group->pad_names[p * group->func_count],</span><br><span style="color: hsl(0, 100%, 40%);">- decode_pad_mode(group, p, dw0));</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("0x%04zx: /* %-8s %-20s 0x%016"PRIx64" */ ",</span><br><span style="color: hsl(120, 100%, 40%);">+ pad_cfg, group->pad_names[p * group->func_count],</span><br><span style="color: hsl(120, 100%, 40%);">+ decode_pad_mode(group, p, dw0),</span><br><span style="color: hsl(120, 100%, 40%);">+ (uint64_t)dw1 << 32 | dw0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (print_table_gpio(group, p, dw0, dw1))</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("PAD_CFG_UNSUPPORTED,\n");</span><br><span> }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25145">change 25145</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25145"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id8895f5d76ba2984fbda757fc00a42ac0ae852d4 </div>
<div style="display:none"> Gerrit-Change-Number: 25145 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>