<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25018">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">timestamps: Add timestamps around the vbios load & init<br><br>Add timestamps before and after the vBIOS load and after the vBIOS<br>run.  This lets us see exactly how long it took to load it from the<br>ROM chip, and how long it takes to run.<br><br>BUG=b:64549506<br>TEST=Build & boot Grunt, see vBIOS load & initialization times.<br><br>Change-Id: I878ba653eb086ad6c6614aa08a6d3fe216a9323e<br>Signed-off-by: Martin Roth <martinroth@chromium.org><br>---<br>M src/commonlib/include/commonlib/timestamp_serialized.h<br>M src/device/pci_device.c<br>2 files changed, 11 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/25018/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/commonlib/include/commonlib/timestamp_serialized.h b/src/commonlib/include/commonlib/timestamp_serialized.h</span><br><span>index de92c72..67bff66 100644</span><br><span>--- a/src/commonlib/include/commonlib/timestamp_serialized.h</span><br><span>+++ b/src/commonlib/include/commonlib/timestamp_serialized.h</span><br><span>@@ -54,6 +54,9 @@</span><br><span>     TS_DEVICE_CONFIGURE = 40,</span><br><span>    TS_DEVICE_ENABLE = 50,</span><br><span>       TS_DEVICE_INITIALIZE = 60,</span><br><span style="color: hsl(120, 100%, 40%);">+    TS_OPTROM_INITIALIZE = 65,</span><br><span style="color: hsl(120, 100%, 40%);">+    TS_OPTROM_COPY_END = 66,</span><br><span style="color: hsl(120, 100%, 40%);">+      TS_OPTROM_END = 67,</span><br><span>  TS_DEVICE_DONE = 70,</span><br><span>         TS_CBMEM_POST = 75,</span><br><span>  TS_WRITE_TABLES = 80,</span><br><span>@@ -166,6 +169,9 @@</span><br><span>  { TS_DEVICE_CONFIGURE,  "device configuration" },</span><br><span>  { TS_DEVICE_ENABLE,     "device enable" },</span><br><span>         { TS_DEVICE_INITIALIZE, "device initialization" },</span><br><span style="color: hsl(120, 100%, 40%);">+  { TS_OPTROM_INITIALIZE, "Optionrom initialization" },</span><br><span style="color: hsl(120, 100%, 40%);">+       { TS_OPTROM_COPY_END,   "Optionrom copy done" },</span><br><span style="color: hsl(120, 100%, 40%);">+    { TS_OPTROM_END,        "Optionrom run done"   },</span><br><span>  { TS_DEVICE_DONE,       "device setup done" },</span><br><span>     { TS_CBMEM_POST,        "cbmem post" },</span><br><span>    { TS_WRITE_TABLES,      "write tables" },</span><br><span>diff --git a/src/device/pci_device.c b/src/device/pci_device.c</span><br><span>index 02eca66..53831fd 100644</span><br><span>--- a/src/device/pci_device.c</span><br><span>+++ b/src/device/pci_device.c</span><br><span>@@ -48,6 +48,7 @@</span><br><span> #include <device/hypertransport.h></span><br><span> #include <pc80/i8259.h></span><br><span> #include <security/vboot/vbnv.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <timestamp.h></span><br><span> </span><br><span> u8 pci_moving_config8(struct device *dev, unsigned int reg)</span><br><span> {</span><br><span>@@ -719,6 +720,7 @@</span><br><span> </span><br><span>      if (!should_load_oprom(dev))</span><br><span>                 return;</span><br><span style="color: hsl(120, 100%, 40%);">+       timestamp_add_now(TS_OPTROM_INITIALIZE);</span><br><span> </span><br><span>         rom = pci_rom_probe(dev);</span><br><span>    if (rom == NULL)</span><br><span>@@ -727,6 +729,7 @@</span><br><span>       ram = pci_rom_load(dev, rom);</span><br><span>        if (ram == NULL)</span><br><span>             return;</span><br><span style="color: hsl(120, 100%, 40%);">+       timestamp_add_now(TS_OPTROM_COPY_END);</span><br><span> </span><br><span>   if (!should_run_oprom(dev))</span><br><span>          return;</span><br><span>@@ -734,6 +737,8 @@</span><br><span>        run_bios(dev, (unsigned long)ram);</span><br><span>   gfx_set_init_done(1);</span><br><span>        printk(BIOS_DEBUG, "VGA Option ROM was run\n");</span><br><span style="color: hsl(120, 100%, 40%);">+     timestamp_add_now(TS_OPTROM_END);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> }</span><br><span> </span><br><span> /** Default device operation for PCI devices */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25018">change 25018</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25018"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I878ba653eb086ad6c6614aa08a6d3fe216a9323e </div>
<div style="display:none"> Gerrit-Change-Number: 25018 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>