<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/24989">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/cyan: fix ACPI interrupt triggering for audio codecs<br><br>Adjust GpioInt trigger type for both LPEA and audio codec<br>to match Intel CHT reference code.  Fixes jack detection<br>under Windows.<br><br>Test: boot Windows on google/egdar, observe headphone insertion/<br>removal produces audio output on the expected device.<br><br>Change-Id: Ic1dd8ece610d761791c060ece2d0aa51addf97ad<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/mainboard/google/cyan/acpi/codec_maxim.asl<br>M src/mainboard/google/cyan/acpi/codec_realtek.asl<br>2 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/24989/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/cyan/acpi/codec_maxim.asl b/src/mainboard/google/cyan/acpi/codec_maxim.asl</span><br><span>index 9abc91e..f805ea1 100644</span><br><span>--- a/src/mainboard/google/cyan/acpi/codec_maxim.asl</span><br><span>+++ b/src/mainboard/google/cyan/acpi/codec_maxim.asl</span><br><span>@@ -47,7 +47,7 @@</span><br><span>                                   "\\_SB.PCI0.I2C2",    /* ResourceSource: I2C bus controller name */</span><br><span>                                )</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-                           GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,</span><br><span style="color: hsl(120, 100%, 40%);">+                                GpioInt (Edge, ActiveHigh, ExclusiveAndWake, PullNone,,</span><br><span>                                      "\\_SB.GPSE") { BOARD_JACK_MAXIM_GPIO_INDEX }</span><br><span>                      } )</span><br><span>                  Return (SBUF)</span><br><span>@@ -91,7 +91,7 @@</span><br><span>                                    "\\_SB.PCI0.I2C2",    /* ResourceSource: I2C bus controller name */</span><br><span>                                )</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-                           GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,</span><br><span style="color: hsl(120, 100%, 40%);">+                                GpioInt (Edge, ActiveHigh, ExclusiveAndWake, PullNone,,</span><br><span>                                      "\\_SB.GPSW") { BOARD_JACK_TI_GPIO_INDEX }</span><br><span> </span><br><span>                     } )</span><br><span>@@ -111,7 +111,7 @@</span><br><span>    Name (GBUF, ResourceTemplate ()</span><br><span>      {</span><br><span>            /* Jack Detect (index 0) */</span><br><span style="color: hsl(0, 100%, 40%);">-             GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,</span><br><span style="color: hsl(120, 100%, 40%);">+                GpioInt (Edge, ActiveBoth, ExclusiveAndWake, PullNone,,</span><br><span>                      "\\_SB.GPSE") { BOARD_JACK_MAXIM_GPIO_INDEX }</span><br><span>      })</span><br><span> }</span><br><span>diff --git a/src/mainboard/google/cyan/acpi/codec_realtek.asl b/src/mainboard/google/cyan/acpi/codec_realtek.asl</span><br><span>index d3fa84e..35aa64d 100644</span><br><span>--- a/src/mainboard/google/cyan/acpi/codec_realtek.asl</span><br><span>+++ b/src/mainboard/google/cyan/acpi/codec_realtek.asl</span><br><span>@@ -39,7 +39,7 @@</span><br><span>                             )</span><br><span> </span><br><span>                         /* Jack Detect (index 0) */</span><br><span style="color: hsl(0, 100%, 40%);">-                     GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,</span><br><span style="color: hsl(120, 100%, 40%);">+                        GpioInt (Edge, ActiveHigh, ExclusiveAndWake, PullNone,,</span><br><span>                               "\\_SB.GPSW") { JACK_DETECT_GPIO_INDEX }</span><br><span>                         } )</span><br><span>                  Return (SBUF)</span><br><span>@@ -57,7 +57,7 @@</span><br><span>    Name (GBUF, ResourceTemplate ()</span><br><span>      {</span><br><span>            /* Jack Detect (index 0) */</span><br><span style="color: hsl(0, 100%, 40%);">-             GpioInt (Edge, ActiveLow, ExclusiveAndWake, PullNone,,</span><br><span style="color: hsl(120, 100%, 40%);">+                GpioInt (Edge, ActiveBoth, ExclusiveAndWake, PullNone,,</span><br><span>                       "\\_SB.GPSW") { JACK_DETECT_GPIO_INDEX }</span><br><span>  })</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/24989">change 24989</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/24989"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic1dd8ece610d761791c060ece2d0aa51addf97ad </div>
<div style="display:none"> Gerrit-Change-Number: 24989 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>