<p><a href="https://review.coreboot.org/23651">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/Makefile.inc">File src/mainboard/hp/8770w/Makefile.inc:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/Makefile.inc@18">Patch Set #1, Line 18:</a> <code style="font-family:monospace,monospace">ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">no libgfxinit in this board</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/devicetree.cb">File src/mainboard/hp/8770w/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/devicetree.cb@119">Patch Set #1, Line 119:</a> <code style="font-family:monospace,monospace">                                 register "ec_fan_ctrl_value" = "0x6b"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I found ec_fan_ctrl_value is 0x81 in one of the firmware update image (http://ftp.hp.com/pub/softpaq/sp57501-58000/sp57870.tgz) with the script in https://www.coreboot.org/HP_Elitebook.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Other values may be ok (and the OEM firmware can set it to 0xff on some condition), but I don't know the effect of this value.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23651">change 23651</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23651"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic4ff64e9cf0c7a51ac48ca2fe6fe8beab02e9f9a </div>
<div style="display:none"> Gerrit-Change-Number: 23651 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Robert Reeves <xiinc37@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Robert Reeves <xiinc37@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Iru Cai <mytbk920423@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 04 Mar 2018 04:16:20 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>