<p>Alex Thiessen has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/24980">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/gitconfig: support pre-v2.5.0 git<br><br>In commit fda071ca "Make gitconfig.sh support gitfile", the<br>`gitconfig.sh` was changed to use `git rev-parse --git-path hooks` to<br>determine the path to copy the hooks to. The `--git-path` option was<br>added only recently on 2014-11-30 in git v2.5.0-rc0 commit 557bd833<br>"git_path(): be aware of file relocation in $GIT_DIR". Hence, for users<br>of older distributions (e.g. Ubuntu 14.04) the `make gitconfig` stopped<br>working.<br><br>This commit adds a script that provides functions for comparing git<br>versions and modifies the `gitconfig.sh` script to use a simpler method<br>for `hooks` directory lookup when an older, pre-v2.5.0-rc0 git is<br>found installed.<br><br>Change-Id: I4754fd51d6565960a756df852099dcf0bca72c71<br>Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com><br>---<br>M util/gitconfig/gitconfig.sh<br>A util/scripts/git-version-compare.sh<br>2 files changed, 233 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/24980/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/gitconfig/gitconfig.sh b/util/gitconfig/gitconfig.sh</span><br><span>index 5d6fe36..4934dbd 100755</span><br><span>--- a/util/gitconfig/gitconfig.sh</span><br><span>+++ b/util/gitconfig/gitconfig.sh</span><br><span>@@ -24,7 +24,15 @@</span><br><span> echo "Error: Not in root of a git repository"</span><br><span> exit 1</span><br><span> fi</span><br><span style="color: hsl(0, 100%, 40%);">-coreboot_hooks=$(git rev-parse --git-path hooks)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+source util/scripts/git-version-compare.sh</span><br><span style="color: hsl(120, 100%, 40%);">+# `rev-parse --git-path` was added in commit 557bd833 for v2.5.0-rc0</span><br><span style="color: hsl(120, 100%, 40%);">+if git_version_ge 2 5 0 0; then</span><br><span style="color: hsl(120, 100%, 40%);">+ coreboot_hooks=$(git rev-parse --git-path hooks)</span><br><span style="color: hsl(120, 100%, 40%);">+else</span><br><span style="color: hsl(120, 100%, 40%);">+ coreboot_hooks=$(git rev-parse --git-dir)/hooks</span><br><span style="color: hsl(120, 100%, 40%);">+fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> mkdir -p "${coreboot_hooks}"</span><br><span> for hook in commit-msg pre-commit ; do</span><br><span> if [ util/gitconfig/${hook} -nt "${coreboot_hooks}/${hook}" ] \</span><br><span>diff --git a/util/scripts/git-version-compare.sh b/util/scripts/git-version-compare.sh</span><br><span>new file mode 100644</span><br><span>index 0000000..54f3de3</span><br><span>--- /dev/null</span><br><span>+++ b/util/scripts/git-version-compare.sh</span><br><span>@@ -0,0 +1,224 @@</span><br><span style="color: hsl(120, 100%, 40%);">+#!/bin/sh</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+##</span><br><span style="color: hsl(120, 100%, 40%);">+## This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+##</span><br><span style="color: hsl(120, 100%, 40%);">+## Copyright (C) 2003-2018 Alex Thiessen <alex.thiessen.de+coreboot@gmail.com></span><br><span style="color: hsl(120, 100%, 40%);">+##</span><br><span style="color: hsl(120, 100%, 40%);">+## This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+## it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+## the Free Software Foundation; version 3 or later of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+##</span><br><span style="color: hsl(120, 100%, 40%);">+## This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+## but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+## GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+##</span><br><span style="color: hsl(120, 100%, 40%);">+## SPDX-License-Identifier: GPL-3.0-or-later</span><br><span style="color: hsl(120, 100%, 40%);">+## <https://spdx.org/licenses/GPL-3.0-or-later.html></span><br><span style="color: hsl(120, 100%, 40%);">+##</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# dependency check</span><br><span style="color: hsl(120, 100%, 40%);">+for dependency in cut false git grep true; do</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! command -v "${dependency}" 1>/dev/null; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo "missing ${dependency}, please install first" >&2</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+done</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+get_git_version_part() {</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! [ ${#} -eq 1 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 'usage: get_git_version_part <version part number>'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 'i.e.: 2.5.0-rc1'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 ' ^ ^ ^ ^'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 ' 1 2 3 4 <version part number>'</span><br><span style="color: hsl(120, 100%, 40%);">+ false; return</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+ part_nr=${1}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! { [ 1 -le "${part_nr}" ] && [ "${part_nr}" -le 4 ]; }; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo 'version part number must be a number between 1 and 4' >&2</span><br><span style="color: hsl(120, 100%, 40%);">+ false; return</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_output=$(git --version)</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ ${?} -ne 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo 'cannot determine `git" version' >&2</span><br><span style="color: hsl(120, 100%, 40%);">+ false; return</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_dotted=$(echo "${git_version_output}" | cut -d' ' -f3)</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ ${?} -ne 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo 'cannot extract `git" version' >&2</span><br><span style="color: hsl(120, 100%, 40%);">+ false; return</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ "${part_nr}" -lt 3 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_part=$(echo "${git_version_dotted}" \</span><br><span style="color: hsl(120, 100%, 40%);">+ | cut -d'.' -f"${part_nr}")</span><br><span style="color: hsl(120, 100%, 40%);">+ else # treat the release candidate part specially</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_part=$(echo "${git_version_dotted}" \</span><br><span style="color: hsl(120, 100%, 40%);">+ | cut -d'.' -f3)</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ ${?} -ne 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo 'cannot extract `git" version part' >&2</span><br><span style="color: hsl(120, 100%, 40%);">+ false; return</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ "${part_nr}" -eq 3 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_part="$(echo "${git_version_part}" \</span><br><span style="color: hsl(120, 100%, 40%);">+ | cut -d'-' -f1)"</span><br><span style="color: hsl(120, 100%, 40%);">+ elif { echo "${git_version_part}" \</span><br><span style="color: hsl(120, 100%, 40%);">+ | grep -Eqx "[0-9]+-rc[0-9]+"; }; then</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_part="$(echo "${git_version_part}" \</span><br><span style="color: hsl(120, 100%, 40%);">+ | sed -E 's/^[0-9+]-rc([0-9]+)$/\1/')"</span><br><span style="color: hsl(120, 100%, 40%);">+ else # not a release candidate</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_part=""</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ ${?} -ne 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo 'cannot extract `git" version part' >&2</span><br><span style="color: hsl(120, 100%, 40%);">+ false; return</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ echo "${git_version_part}"</span><br><span style="color: hsl(120, 100%, 40%);">+ true; return</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+git_version_lt() {</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! { [ 3 -le ${#} ] && [ ${#} -le 4 ]; }; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 'compare installed git version to a specific one'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 'usage: git_version_lt <version>'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 'e.g.: git_version_lt 2 5 0 1'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 ' ^ ^ ^ ^'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 ' 2.5.0-rc1'</span><br><span style="color: hsl(120, 100%, 40%);">+ return 127</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for i in $(seq 1 4); do</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_part_lhs=$(get_git_version_part "${i}")</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! [ ${?} -eq 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ return 127;</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_part_rhs=$(eval echo \$\{"${i}"\})</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! [ ${?} -eq 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ return 127;</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ "${i}" -eq 4 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ # empty release candidate is greater than any other one</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ -z "${git_version_part_lhs}" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ false; return</span><br><span style="color: hsl(120, 100%, 40%);">+ elif [ -z "${git_version_part_rhs}" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ true; return</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ [ "${git_version_part_lhs}" \</span><br><span style="color: hsl(120, 100%, 40%);">+ -lt "${git_version_part_rhs}" ]</span><br><span style="color: hsl(120, 100%, 40%);">+ return</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+ elif [ "${git_version_part_lhs}" \</span><br><span style="color: hsl(120, 100%, 40%);">+ -lt "${git_version_part_rhs}" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ true; return</span><br><span style="color: hsl(120, 100%, 40%);">+ elif [ "${git_version_part_lhs}" \</span><br><span style="color: hsl(120, 100%, 40%);">+ -gt "${git_version_part_rhs}" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ false; return</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+ done</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ # should not get here</span><br><span style="color: hsl(120, 100%, 40%);">+ return 127</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+git_version_ge() {</span><br><span style="color: hsl(120, 100%, 40%);">+ ! git_version_lt "${@}"; return</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+git_version_eq() {</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ ${#} -lt 3 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 'compare installed git version to a specific one'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 'usage: git_version_eq <version>'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 'e.g.: git_version_eq 2 5 0 1'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 ' ^ ^ ^ ^'</span><br><span style="color: hsl(120, 100%, 40%);">+ echo >&2 ' 2.5.0-rc1'</span><br><span style="color: hsl(120, 100%, 40%);">+ return 127</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for i in $(seq 1 4); do</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_part_lhs=$(get_git_version_part "${i}")</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! [ ${?} -eq 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ return 127</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_part_rhs=$(eval echo \$\{"${i}"\})</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! [ ${?} -eq 0 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ return 127</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ "${i}" -eq 4 ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ # special treatment of the release candidates</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ -n "${git_version_part_lhs}" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ -z "${git_version_part_lhs}" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ false; return</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ [ "${git_version_part_lhs}" \</span><br><span style="color: hsl(120, 100%, 40%);">+ -eq "${git_version_part_rhs}" ]; return</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ [ -z "${git_version_part_rhs}" ]; return</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+ done</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ # should not get here</span><br><span style="color: hsl(120, 100%, 40%);">+ return 127</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+git_version_le() {</span><br><span style="color: hsl(120, 100%, 40%);">+ git_version_lt "${@}" || git_version_eq "${@}"; return</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+git_version_gt() {</span><br><span style="color: hsl(120, 100%, 40%);">+ ! git_version_le "${@}"; return</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+test_git_version() {</span><br><span style="color: hsl(120, 100%, 40%);">+ git_real=$(command -v git)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ git() {</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ ${#} -eq 1 ] && [ "${1}" = "--version" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ echo "${git_fake_version}"</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ "${git_real}" "${@}"</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ git_fake_version="git version 1.23.4"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! get_git_version_part ; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! get_git_version_part 0; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if get_git_version_part 1; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if get_git_version_part 2; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if get_git_version_part 3; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if get_git_version_part 4; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! get_git_version_part 5; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! get_git_version_part x; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! git_version_lt 1 11 0 ; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! git_version_lt 1 23 4 1; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! git_version_lt 1 23 4 ; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if git_version_lt 1 23 5 ; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ git_fake_version="git version 2.11.1-rc2"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if git_version_lt 2 12 0 ; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if git_version_lt 2 11 1 ; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if git_version_lt 2 11 1 3; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! git_version_lt 2 11 1 2; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! git_version_lt 2 11 1 1; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+ if ! git_version_lt 2 10 0 ; then echo ok; else echo nok; fi</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+if [ ${#} -eq 1 ] && [ "${1}" = "--test" ]; then</span><br><span style="color: hsl(120, 100%, 40%);">+ test_git_version</span><br><span style="color: hsl(120, 100%, 40%);">+fi</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/24980">change 24980</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/24980"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4754fd51d6565960a756df852099dcf0bca72c71 </div>
<div style="display:none"> Gerrit-Change-Number: 24980 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com> </div>