<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/24974">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel: Fix MCFG end bus number<br><br>The ACPI MCFG table is generated with a static end bus number of 255,<br>which expects that the reserved range in E820 is 256MB. However the<br>actual MCFG range is configurable with Kconfig, so these two values<br>may not match when the OS tries to determine the range:<br><br>PCI: MMCONFIG for domain 0000 [bus 00-ff] at [mem 0xe0000000-0xefffffff] (base 0xe0000000)<br>PCI: MMCONFIG 0000 [bus 00-3f] at [mem 0xe0000000-0xe3ffffff] (base 0xe0000000) (size reduced!)<br>acpi PNP0A08:00: [Firmware Info]: MMCONFIG for domain 0000 [bus 00-3f] only partially covers this bridge<br><br>Instead of forcing the end bus number to be 255 use the Kconfig value<br>to set it based on the current configuration.<br><br>Tested on a fizz device to ensure that the kernel no longer complains:<br><br>PCI: MMCONFIG for domain 0000 [bus 00-3f] at [mem 0xe0000000-0xe3ffffff] (base 0xe0000000)<br><br>Change-Id: I999ea9b72b9deba5f27dd692faa0408427a0bf89<br>Signed-off-by: Duncan Laurie <dlaurie@chromium.org><br>---<br>M src/soc/intel/common/block/acpi/acpi.c<br>M src/soc/intel/skylake/acpi.c<br>2 files changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/24974/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c</span><br><span>index 3db96a0..bf4003d 100644</span><br><span>--- a/src/soc/intel/common/block/acpi/acpi.c</span><br><span>+++ b/src/soc/intel/common/block/acpi/acpi.c</span><br><span>@@ -36,7 +36,7 @@</span><br><span> /* PCI Segment Group 0, Start Bus Number 0, End Bus Number is 255 */</span><br><span> current += acpi_create_mcfg_mmconfig((void *)current,</span><br><span> CONFIG_MMCONF_BASE_ADDRESS, 0, 0,</span><br><span style="color: hsl(0, 100%, 40%);">- 255);</span><br><span style="color: hsl(120, 100%, 40%);">+ (CONFIG_SA_PCIEX_LENGTH >> 20) - 1);</span><br><span> return current;</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c</span><br><span>index 6e1a886..202d686 100644</span><br><span>--- a/src/soc/intel/skylake/acpi.c</span><br><span>+++ b/src/soc/intel/skylake/acpi.c</span><br><span>@@ -210,7 +210,8 @@</span><br><span> unsigned long acpi_fill_mcfg(unsigned long current)</span><br><span> {</span><br><span> current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current,</span><br><span style="color: hsl(0, 100%, 40%);">- MCFG_BASE_ADDRESS, 0, 0, 255);</span><br><span style="color: hsl(120, 100%, 40%);">+ MCFG_BASE_ADDRESS, 0, 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ (CONFIG_SA_PCIEX_LENGTH >> 20) - 1);</span><br><span> return current;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/24974">change 24974</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/24974"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I999ea9b72b9deba5f27dd692faa0408427a0bf89 </div>
<div style="display:none"> Gerrit-Change-Number: 24974 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>