<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/24975">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Remove MCFG constants<br><br>The MMCONF base address and length are set in Kconfig so it does<br>not need to be redefined by the SOC as the code can just use the<br>Kconfig variable directly.<br><br>Tested on a fizz board to ensure MCFG is still created properly.<br><br>Change-Id: I5fd472b1afc8264823a2b9db0f296fbfb6b1ecc0<br>Signed-off-by: Duncan Laurie <dlaurie@chromium.org><br>---<br>M src/soc/intel/skylake/acpi.c<br>M src/soc/intel/skylake/include/soc/iomap.h<br>2 files changed, 1 insertion(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/24975/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c</span><br><span>index 202d686..2e0d87a 100644</span><br><span>--- a/src/soc/intel/skylake/acpi.c</span><br><span>+++ b/src/soc/intel/skylake/acpi.c</span><br><span>@@ -210,7 +210,7 @@</span><br><span> unsigned long acpi_fill_mcfg(unsigned long current)</span><br><span> {</span><br><span>    current += acpi_create_mcfg_mmconfig((acpi_mcfg_mmconfig_t *)current,</span><br><span style="color: hsl(0, 100%, 40%);">-                                        MCFG_BASE_ADDRESS, 0, 0,</span><br><span style="color: hsl(120, 100%, 40%);">+                                      CONFIG_MMCONF_BASE_ADDRESS, 0, 0,</span><br><span>                                            (CONFIG_SA_PCIEX_LENGTH >> 20) - 1);</span><br><span>      return current;</span><br><span> }</span><br><span>diff --git a/src/soc/intel/skylake/include/soc/iomap.h b/src/soc/intel/skylake/include/soc/iomap.h</span><br><span>index 0a573ac..ac0c78b 100644</span><br><span>--- a/src/soc/intel/skylake/include/soc/iomap.h</span><br><span>+++ b/src/soc/intel/skylake/include/soc/iomap.h</span><br><span>@@ -22,9 +22,6 @@</span><br><span> /*</span><br><span>  * Memory-mapped I/O registers.</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-#define MCFG_BASE_ADDRESS      CONFIG_MMCONF_BASE_ADDRESS</span><br><span style="color: hsl(0, 100%, 40%);">-#define MCFG_BASE_SIZE                0x4000000</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #define PCH_PRESERVED_BASE_ADDRESS      0xfc800000</span><br><span> #define PCH_PRESERVED_BASE_SIZE 0x02000000</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/24975">change 24975</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/24975"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5fd472b1afc8264823a2b9db0f296fbfb6b1ecc0 </div>
<div style="display:none"> Gerrit-Change-Number: 24975 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>