<p><a href="https://review.coreboot.org/24909">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/24909/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/24909/1//COMMIT_MSG@7">Patch Set #1, Line 7:</a> <code style="font-family:monospace,monospace">src/mainboard/intel</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">mb/intel/glkrvp</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/24909/1/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c">File src/mainboard/intel/glkrvp/variants/baseboard/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/24909/1/src/mainboard/intel/glkrvp/variants/baseboard/gpio.c@198">Patch Set #1, Line 198:</a> <code style="font-family:monospace,monospace">GPIO_163</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is there an external pull-up on this? Else, you might want to do this configuration early in bootblock.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/24909">change 24909</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/24909"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic594c5a088af79079a8742f5287ed66dcc0ff067 </div>
<div style="display:none"> Gerrit-Change-Number: 24909 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Roy Mingi Park <roy.mingi.park@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Shamile Khan <shamile.khan@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Feb 2018 23:09:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>