<p>Nick Vaccaro would like Nick Vaccaro to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/23874">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/zoombini: consolidate SPD makefiles<br><br>- consolidate commonality in meowth and zoombini's SPD makefiles into<br> a common zoombini/spd/Makefile.inc<br>- move all SPD hex files into zoombini/spd directory<br>- move SPD_SOURCES definitions to variants/$(VARIANT_DIR)/Makefile.inc<br><br>BUG=b:69011806,b:71776625<br>BRANCH=master<br>TEST=Verify 'emerge-meowth coreboot' and 'emerge-zoombini coreboot'<br>compile and boot successfully.<br><br>Change-Id: I2291ebaf0ef5da1b22eb0e8fa7af8dbb50848c29<br>Signed-off-by: Nick Vaccaro <nvaccaro@chromium.org><br>---<br>M src/mainboard/google/zoombini/Makefile.inc<br>R src/mainboard/google/zoombini/spd/Hynix_H9HCNNN8KUMLHR_1GB.spd.hex<br>R src/mainboard/google/zoombini/spd/Hynix_H9HCNNNCPUMLHR_4GB.spd.hex<br>A src/mainboard/google/zoombini/spd/Makefile.inc<br>R src/mainboard/google/zoombini/spd/Micron_MT53B1024M32D4_4GB.spd.hex<br>R src/mainboard/google/zoombini/spd/Micron_MT53B512M32D2_2GB.spd.hex<br>R src/mainboard/google/zoombini/spd/Samsung_K4F6E3S4HM_2GB.spd.hex<br>R src/mainboard/google/zoombini/spd/Samsung_K4F8E304HB_1GB.spd.hex<br>M src/mainboard/google/zoombini/variants/meowth/Makefile.inc<br>D src/mainboard/google/zoombini/variants/meowth/spd/Makefile.inc<br>A src/mainboard/google/zoombini/variants/zoombini/Makefile.inc<br>D src/mainboard/google/zoombini/variants/zoombini/spd/Hynix_H9HCNNN8KUMLHR_1GB.spd.hex<br>D src/mainboard/google/zoombini/variants/zoombini/spd/Makefile.inc<br>13 files changed, 29 insertions(+), 110 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/23874/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/zoombini/Makefile.inc b/src/mainboard/google/zoombini/Makefile.inc</span><br><span>index e4a036d..b1e31b4 100644</span><br><span>--- a/src/mainboard/google/zoombini/Makefile.inc</span><br><span>+++ b/src/mainboard/google/zoombini/Makefile.inc</span><br><span>@@ -38,3 +38,5 @@</span><br><span> subdirs-y += variants/$(VARIANT_DIR)</span><br><span> CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include</span><br><span> subdirs-y += variants/$(VARIANT_DIR)/spd</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+subdirs-y += spd</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNN8KUMLHR_1GB.spd.hex b/src/mainboard/google/zoombini/spd/Hynix_H9HCNNN8KUMLHR_1GB.spd.hex</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNN8KUMLHR_1GB.spd.hex</span><br><span>rename to src/mainboard/google/zoombini/spd/Hynix_H9HCNNN8KUMLHR_1GB.spd.hex</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNCPUMLHR_4GB.spd.hex b/src/mainboard/google/zoombini/spd/Hynix_H9HCNNNCPUMLHR_4GB.spd.hex</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/google/zoombini/variants/meowth/spd/Hynix_H9HCNNNCPUMLHR_4GB.spd.hex</span><br><span>rename to src/mainboard/google/zoombini/spd/Hynix_H9HCNNNCPUMLHR_4GB.spd.hex</span><br><span>diff --git a/src/mainboard/google/zoombini/spd/Makefile.inc b/src/mainboard/google/zoombini/spd/Makefile.inc</span><br><span>new file mode 100644</span><br><span>index 0000000..b73ddd2</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/zoombini/spd/Makefile.inc</span><br><span>@@ -0,0 +1,19 @@</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_BIN = $(obj)/spd.bin</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ifeq ($(SPD_SOURCES),)</span><br><span style="color: hsl(120, 100%, 40%);">+ SPD_DEPS := $(error SPD_SOURCES is not set. Variant must provide this)</span><br><span style="color: hsl(120, 100%, 40%);">+else</span><br><span style="color: hsl(120, 100%, 40%);">+ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)</span><br><span style="color: hsl(120, 100%, 40%);">+endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# Include spd ROM data</span><br><span style="color: hsl(120, 100%, 40%);">+$(SPD_BIN): $(SPD_DEPS)</span><br><span style="color: hsl(120, 100%, 40%);">+ for f in $+; \</span><br><span style="color: hsl(120, 100%, 40%);">+ do for c in $$(cat $$f | grep -v ^#); \</span><br><span style="color: hsl(120, 100%, 40%);">+ do printf $$(printf '\%o' 0x$$c); \</span><br><span style="color: hsl(120, 100%, 40%);">+ done; \</span><br><span style="color: hsl(120, 100%, 40%);">+ done > $@</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+cbfs-files-y += spd.bin</span><br><span style="color: hsl(120, 100%, 40%);">+spd.bin-file := $(SPD_BIN)</span><br><span style="color: hsl(120, 100%, 40%);">+spd.bin-type := spd</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/zoombini/spd/Micron_MT53B1024M32D4_4GB.spd.hex b/src/mainboard/google/zoombini/spd/Micron_MT53B1024M32D4_4GB.spd.hex</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/google/zoombini/variants/zoombini/spd/Micron_MT53B1024M32D4_4GB.spd.hex</span><br><span>rename to src/mainboard/google/zoombini/spd/Micron_MT53B1024M32D4_4GB.spd.hex</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/zoombini/spd/Micron_MT53B512M32D2_2GB.spd.hex b/src/mainboard/google/zoombini/spd/Micron_MT53B512M32D2_2GB.spd.hex</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/google/zoombini/variants/zoombini/spd/Micron_MT53B512M32D2_2GB.spd.hex</span><br><span>rename to src/mainboard/google/zoombini/spd/Micron_MT53B512M32D2_2GB.spd.hex</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/meowth/spd/Samsung_K4F6E3S4HM_2GB.spd.hex b/src/mainboard/google/zoombini/spd/Samsung_K4F6E3S4HM_2GB.spd.hex</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/google/zoombini/variants/meowth/spd/Samsung_K4F6E3S4HM_2GB.spd.hex</span><br><span>rename to src/mainboard/google/zoombini/spd/Samsung_K4F6E3S4HM_2GB.spd.hex</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/meowth/spd/Samsung_K4F8E304HB_1GB.spd.hex b/src/mainboard/google/zoombini/spd/Samsung_K4F8E304HB_1GB.spd.hex</span><br><span>similarity index 100%</span><br><span>rename from src/mainboard/google/zoombini/variants/meowth/spd/Samsung_K4F8E304HB_1GB.spd.hex</span><br><span>rename to src/mainboard/google/zoombini/spd/Samsung_K4F8E304HB_1GB.spd.hex</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/meowth/Makefile.inc b/src/mainboard/google/zoombini/variants/meowth/Makefile.inc</span><br><span>index 51ebbad..487bc44 100644</span><br><span>--- a/src/mainboard/google/zoombini/variants/meowth/Makefile.inc</span><br><span>+++ b/src/mainboard/google/zoombini/variants/meowth/Makefile.inc</span><br><span>@@ -13,6 +13,11 @@</span><br><span> ## GNU General Public License for more details.</span><br><span> ##</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES = Samsung_K4F8E304HB_1GB # 0b000</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += Hynix_H9HCNNN8KUMLHR_1GB # 0b001</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += Samsung_K4F6E3S4HM_2GB # 0b010</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += Hynix_H9HCNNNCPUMLHR_4GB # 0b011</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> bootblock-y += gpio.c</span><br><span> </span><br><span> romstage-y += memory.c</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/meowth/spd/Makefile.inc b/src/mainboard/google/zoombini/variants/meowth/spd/Makefile.inc</span><br><span>deleted file mode 100644</span><br><span>index a4a7955..0000000</span><br><span>--- a/src/mainboard/google/zoombini/variants/meowth/spd/Makefile.inc</span><br><span>+++ /dev/null</span><br><span>@@ -1,40 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## Copyright 2017 Google Inc.</span><br><span style="color: hsl(0, 100%, 40%);">-## Copyright (C) 2017 Intel Corporation.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">-## it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">-## the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">-## but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">-## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">-## GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_BIN = $(obj)/spd.bin</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES = Samsung_K4F8E304HB_1GB # 0b000</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES += Hynix_H9HCNNN8KUMLHR_1GB # 0b001</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES += Samsung_K4F6E3S4HM_2GB # 0b010</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES += Hynix_H9HCNNNCPUMLHR_4GB # 0b011</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-ifeq ($(SPD_SOURCES),)</span><br><span style="color: hsl(0, 100%, 40%);">- SPD_DEPS := $(error SPD_SOURCES is not set. Variant must provide this)</span><br><span style="color: hsl(0, 100%, 40%);">-else</span><br><span style="color: hsl(0, 100%, 40%);">- SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/variants/meowth/spd/$(f).spd.hex)</span><br><span style="color: hsl(0, 100%, 40%);">-endif</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-# Include spd ROM data</span><br><span style="color: hsl(0, 100%, 40%);">-$(SPD_BIN): $(SPD_DEPS)</span><br><span style="color: hsl(0, 100%, 40%);">- for f in $+; \</span><br><span style="color: hsl(0, 100%, 40%);">- do for c in $$(cat $$f | grep -v ^#); \</span><br><span style="color: hsl(0, 100%, 40%);">- do printf $$(printf '\%o' 0x$$c); \</span><br><span style="color: hsl(0, 100%, 40%);">- done; \</span><br><span style="color: hsl(0, 100%, 40%);">- done > $@</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-cbfs-files-y += spd.bin</span><br><span style="color: hsl(0, 100%, 40%);">-spd.bin-file := $(SPD_BIN)</span><br><span style="color: hsl(0, 100%, 40%);">-spd.bin-type := spd</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/zoombini/Makefile.inc b/src/mainboard/google/zoombini/variants/zoombini/Makefile.inc</span><br><span>new file mode 100644</span><br><span>index 0000000..6007e12</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/zoombini/variants/zoombini/Makefile.inc</span><br><span>@@ -0,0 +1,3 @@</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES = Hynix_H9HCNNN8KUMLHR_1GB # 0b000</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += Micron_MT53B512M32D2_2GB # 0b001</span><br><span style="color: hsl(120, 100%, 40%);">+SPD_SOURCES += Micron_MT53B1024M32D4_4GB # 0b010</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/zoombini/spd/Hynix_H9HCNNN8KUMLHR_1GB.spd.hex b/src/mainboard/google/zoombini/variants/zoombini/spd/Hynix_H9HCNNN8KUMLHR_1GB.spd.hex</span><br><span>deleted file mode 100644</span><br><span>index 7b13b4d..0000000</span><br><span>--- a/src/mainboard/google/zoombini/variants/zoombini/spd/Hynix_H9HCNNN8KUMLHR_1GB.spd.hex</span><br><span>+++ /dev/null</span><br><span>@@ -1,32 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-23 11 10 0E 15 19 05 08 00 40 00 00 02 22 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-48 00 05 FF 92 55 00 00 8C 00 90 A8 90 A0 05 D0</span><br><span style="color: hsl(0, 100%, 40%);">-02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 9E 00 A7 CF D0</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 80 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span style="color: hsl(0, 100%, 40%);">-00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00</span><br><span>diff --git a/src/mainboard/google/zoombini/variants/zoombini/spd/Makefile.inc b/src/mainboard/google/zoombini/variants/zoombini/spd/Makefile.inc</span><br><span>deleted file mode 100644</span><br><span>index a0bf3e3..0000000</span><br><span>--- a/src/mainboard/google/zoombini/variants/zoombini/spd/Makefile.inc</span><br><span>+++ /dev/null</span><br><span>@@ -1,38 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This file is part of the coreboot project.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## Copyright 2017 Google Inc.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(0, 100%, 40%);">-## it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(0, 100%, 40%);">-## the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-## This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(0, 100%, 40%);">-## but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(0, 100%, 40%);">-## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(0, 100%, 40%);">-## GNU General Public License for more details.</span><br><span style="color: hsl(0, 100%, 40%);">-##</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_BIN = $(obj)/spd.bin</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES = Hynix_H9HCNNN8KUMLHR_1GB # 0b000</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES += Micron_MT53B512M32D2_2GB # 0b001</span><br><span style="color: hsl(0, 100%, 40%);">-SPD_SOURCES += Micron_MT53B1024M32D4_4GB # 0b010</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-ifeq ($(SPD_SOURCES),)</span><br><span style="color: hsl(0, 100%, 40%);">- SPD_DEPS := $(error SPD_SOURCES is not set. Variant must provide this)</span><br><span style="color: hsl(0, 100%, 40%);">-else</span><br><span style="color: hsl(0, 100%, 40%);">- SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/variants/zoombini/spd/$(f).spd.hex)</span><br><span style="color: hsl(0, 100%, 40%);">-endif</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-# Include spd ROM data</span><br><span style="color: hsl(0, 100%, 40%);">-$(SPD_BIN): $(SPD_DEPS)</span><br><span style="color: hsl(0, 100%, 40%);">- for f in $+; \</span><br><span style="color: hsl(0, 100%, 40%);">- do for c in $$(cat $$f | grep -v ^#); \</span><br><span style="color: hsl(0, 100%, 40%);">- do printf $$(printf '\%o' 0x$$c); \</span><br><span style="color: hsl(0, 100%, 40%);">- done; \</span><br><span style="color: hsl(0, 100%, 40%);">- done > $@</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-cbfs-files-y += spd.bin</span><br><span style="color: hsl(0, 100%, 40%);">-spd.bin-file := $(SPD_BIN)</span><br><span style="color: hsl(0, 100%, 40%);">-spd.bin-type := spd</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23874">change 23874</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23874"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2291ebaf0ef5da1b22eb0e8fa7af8dbb50848c29 </div>
<div style="display:none"> Gerrit-Change-Number: 23874 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org> </div>