<p>Justin TerAvest has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23830">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/kahlee: Use GPIO macros for baseboard<br><br>This commit uses newly defined macros to make it easier to read which<br>iomux function pads are being configured to use.<br><br>TEST=Booted grunt, confirmed display backlight came on.<br>BUG=b:72875858<br><br>Change-Id: I24e5091fc7ef696f8e9c932ce04664e6cc3ccb90<br>Signed-off-by: Justin TerAvest <teravest@chromium.org><br>---<br>M src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>1 file changed, 71 insertions(+), 74 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/23830/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>index fb7ae96..f4329a1 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>@@ -21,101 +21,98 @@</span><br><span> #include <stdlib.h></span><br><span> </span><br><span> /*</span><br><span style="color: hsl(0, 100%, 40%);">- * These settings were generated by a spreadsheet. If they need to be updated,</span><br><span style="color: hsl(0, 100%, 40%);">- * update the spreadsheet shared with the Grunt development team.</span><br><span style="color: hsl(0, 100%, 40%);">- *</span><br><span> * As a rule of thumb, GPIO pins used by coreboot should be initialized at</span><br><span> * bootblock while GPIO pins used only by the OS should be initialized at</span><br><span> * ramstage.</span><br><span> */</span><br><span> const static struct soc_amd_stoneyridge_gpio gpio_set_stage_reset[] = {</span><br><span> /* GPIO_0 - EC_PCH_PWR_BTN_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_0, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_0, PWR_BTN_L, PULL_UP),</span><br><span> </span><br><span> /* GPIO_1 - SYS_RST_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_1, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_1, SYS_RESET_L, PULL_UP),</span><br><span> </span><br><span> /* GPIO_3 - MEM_VOLT_SEL */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_3, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_3, PULL_UP),</span><br><span> </span><br><span> /* GPIO_4 - EN_PP3300_WLAN */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_4, Function0, OUTPUT_H },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_4, OUT_HIGH),</span><br><span> </span><br><span> /* GPIO_5 - PCH_TRACKPAD_INT_3V3_ODL, SCI */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_5, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_5, PULL_UP),</span><br><span> </span><br><span> /* GPIO_6 - APU_RST_L / EC_SMI_ODL, SMI */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_6, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_6, PULL_UP),</span><br><span> </span><br><span> /* GPIO_7 - APU_PWROK_OD (currently not used) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_7, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_7, PULL_UP),</span><br><span> </span><br><span> /* GPIO_8 - DDR_ALERT_3V3_L (currently not used) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_8, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_8, PULL_UP),</span><br><span> </span><br><span> /* GPIO_9 - H1_PCH_INT_ODL, SCI */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_9, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_9, PULL_UP),</span><br><span> </span><br><span> /* GPIO_11 - TOUCHSCREEN_INT_3V3_ODL, SCI */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_11, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_11, PULL_UP),</span><br><span> </span><br><span> /* GPIO_14 - APU_HP_INT_ODL, SCI */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_14, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_14, PULL_UP),</span><br><span> </span><br><span> /* GPIO_15 - EC_IN_RW_OD */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_15, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_15, PULL_UP),</span><br><span> </span><br><span> /* GPIO_19 - APU_I2C_SCL3 (Touchscreen) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_19, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_19, I2C3_SCL, PULL_UP),</span><br><span> </span><br><span> /* GPIO_20 - APU_I2C_SDA3 (Touchscreen) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_20, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_20, I2C3_SDA, PULL_UP),</span><br><span> </span><br><span> /* GPIO_21 - APU_PEN_INT_ODL, SCI */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_21, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_21, PULL_UP),</span><br><span> </span><br><span> /* GPIO_22 - EC_SCI_ODL, SCI */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_22, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_22, PULL_UP),</span><br><span> </span><br><span> /* GPIO_23 - ACOK_OD */</span><br><span> /* GPIO_24 - USB_A1_OC_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_24, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_24, USB_OC3_L, PULL_UP),</span><br><span> </span><br><span> /* GPIO_25 - SD_CD */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_25, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_25, SD0_CD, PULL_UP),</span><br><span> </span><br><span> /* GPIO_26 - APU_PCIE_RST_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_26, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_40 - EMMC_BRIDGE_RST_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_40, Function0, OUTPUT_H },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_24, OUT_HIGH),</span><br><span> </span><br><span> /* GPIO_42 - S5_MUX_CTRL */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_42, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_42, S5_MUX_CTRL, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_70 - WLAN_PE_RST_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_70, Function0, OUTPUT_H },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_70, OUT_HIGH),</span><br><span> </span><br><span> /* GPIO_74 - LPC_CLK0_EC_R */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_74, Function0, FCH_GPIO_PULL_DOWN_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_74, LPCCLK0, PULL_DOWN),</span><br><span> </span><br><span> /* GPIO_84 - HUB_RST (Active High) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_84, Function1, OUTPUT_L },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_84, OUT_LOW),</span><br><span> </span><br><span> /* GPIO_85 - TOUCHSCREEN_RST (Active High) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_85, Function1, OUTPUT_L },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_85, OUT_LOW),</span><br><span> </span><br><span> /* GPIO_87 - LPC_SERIRQ */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_87, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_87, SERIRQ, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_88 - LPC_CLKRUN_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_88, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_88, LPC_CLKRUN_L, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_92 - WLAN_PCIE_CLKREQ_3V3_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_92, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_92, CLK_REQ0_L, PULL_UP),</span><br><span> </span><br><span> /* GPIO_93 - EMMC_RST_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_93, Function1, OUTPUT_H },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_93, OUT_HIGH),</span><br><span> </span><br><span> /* GPIO_95 - SD_CLK */</span><br><span> /* GPIO_96 - SD_CMD */</span><br><span>@@ -125,137 +122,137 @@</span><br><span> /* GPIO_100 - SD_D3 */</span><br><span> </span><br><span> /* GPIO_101 - SD_WP_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_101, Function0, FCH_GPIO_PULL_DOWN_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_101, SD0_WP, PULL_DOWN),</span><br><span> </span><br><span> /* GPIO_116 - PCIE_EMMC_CLKREQ_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_116, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_116, CLK_REQ2_L, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_117 - PCH_SPI_CLK_R */</span><br><span> </span><br><span> /* GPIO_118 - PCH_SPI_CS0_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_118, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_118, SPI_CS1_L, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_119 - SPK_PA_EN */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_119, Function2, OUTPUT_H },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_119, OUT_HIGH),</span><br><span> </span><br><span> /* GPIO_120 - PCH_SPI_MISO */</span><br><span> /* GPIO_121 - PCH_SPI_MOSI */</span><br><span> </span><br><span> /* GPIO_122 - APU_BIOS_FLASH_WP_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_122, Function1, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_122, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_126 - DMIC_CLK2_EN */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_126, Function1, OUTPUT_H },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_126, OUT_HIGH),</span><br><span> </span><br><span> /* GPIO_129 - APU_KBRST_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_129, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_129, KBRST_L, PULL_UP),</span><br><span> </span><br><span> /* GPIO_131 - CONFIG_STRAP3 */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_131, Function3, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_131, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_132 - CONFIG_STRAP4 */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_132, Function2, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_132, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_133 - APU_EDP_BKLTEN_L (backlight - Active LOW) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_133, Function1, OUTPUT_L },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_133, OUT_LOW),</span><br><span> </span><br><span> /* GPIO_136 - UART_PCH_RX_DEBUG_TX */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_136, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_136, UART0_RXD, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_137 - AUDIO_CLK_EN (Remove in EVT?) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_137, Function1, OUTPUT_H },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_137, OUT_HIGH),</span><br><span> </span><br><span> /* GPIO_138 - UART_PCH_TX_DEBUG_RX */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_138, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_138, UART0_TXD, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_139 - CONFIG_STRAP1 */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_139, Function1, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_139, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_140 - I2S_BCLK_R (init to func0, used for I2S) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_140, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_140, UART1_CTS_L, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_141 - I2S2_DATA_MIC2 (init to func0, used for I2S) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_141, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_141, UART1_RXD, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_142 - CONFIG_STRAP2 */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_142, Function1, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_142, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_143 - I2S2_DATA (init to func0, used for I2S) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_143, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_143, UART1_TXD, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_144 - I2S_LR_R (init to func0, used for I2S) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_144, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_144, UART1_INTR, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_145 - PCH_I2C_AUDIO_SCL */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_145, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_145, I2C0_SCL, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_146 - PCH_I2C_AUDIO_SDA */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_146, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_146, I2C0_SDA, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_147 - PCH_I2C_H1_TPM_SCL */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_147, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_147, I2C1_SCL, PULL_NONE),</span><br><span> </span><br><span> /* GPIO_148 - PCH_I2C_H1_TPM_SDA */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_148, Function0, INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_148, I2C1_SDA, PULL_NONE),</span><br><span> };</span><br><span> </span><br><span> const static struct soc_amd_stoneyridge_gpio gpio_set_stage_ram[] = {</span><br><span> /* GPIO_2 - WLAN_PCIE_WAKE_3V3_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_2, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_2, WAKE_L, PULL_UP),</span><br><span> </span><br><span> /* GPIO_10 - SLP_S0_L (currently not used) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_10, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_10, S0A3_GPIO, PULL_UP),</span><br><span> </span><br><span> /* GPIO_12 - Unused (TP126) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_12, Function2, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_12, PULL_UP),</span><br><span> </span><br><span> /* GPIO_13 - APU_PEN_PDCT_ODL (currently not used) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_13, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_13, PULL_UP),</span><br><span> </span><br><span> /* GPIO_16 - USB_C0_OC_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_16, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_16, USB_OC0_L, PULL_UP),</span><br><span> </span><br><span> /* GPIO_17 - USB_C1_OC_L */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_17, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_17, USB_OC1_L, PULL_UP),</span><br><span> </span><br><span> /* GPIO_18 - USB_A0_OC_ODL */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_18, Function0, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_18, USB_OC2_L, PULL_UP),</span><br><span> </span><br><span> /* GPIO_67 - PEN_RESET */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_67, Function0, OUTPUT_L },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_67, OUT_LOW),</span><br><span> </span><br><span> /* GPIO_75 - Unused (strap) (R139/R130) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_75, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_75, PULL_UP),</span><br><span> </span><br><span> /* GPIO_76 - EN_PP3300_TOUCHSCREEN */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_76, Function0, OUTPUT_H },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_76, OUT_HIGH),</span><br><span> </span><br><span> /* GPIO_86 - Unused (TP109) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_86, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_86, PULL_UP),</span><br><span> </span><br><span> /* GPIO_90 - EN_PP3300_CAMERA */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_90, Function0, OUTPUT_H },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_90, OUT_HIGH),</span><br><span> </span><br><span> /* GPIO_91 - EN_PP3300_TRACKPAD */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_91, Function1, OUTPUT_H },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPO(GPIO_91, OUT_HIGH),</span><br><span> </span><br><span> /* GPIO_102 - EN_SD_SOCKET_PWR */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_102, Function0, FCH_GPIO_PULL_DOWN_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_102, SD0_PWR_CTRL, PULL_DOWN),</span><br><span> </span><br><span> /* GPIO_113 - APU_I2C_SCL2 (Pen & Trackpad) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_113, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_113, I2C2_SCL, PULL_UP),</span><br><span> </span><br><span> /* GPIO_114 - APU_I2C_SDA2 (Pen & Trackpad) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_114, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_NF(GPIO_114, I2C2_SDA, PULL_UP),</span><br><span> </span><br><span> /* GPIO_115 - Unused (TP127) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_115, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_115, PULL_UP),</span><br><span> </span><br><span> /* GPIO_130 - Unused (TP55) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_130, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_130, PULL_UP),</span><br><span> </span><br><span> /* GPIO_135 - Unused (TP128) */</span><br><span style="color: hsl(0, 100%, 40%);">- { GPIO_135, Function1, FCH_GPIO_PULL_UP_ENABLE | INPUT },</span><br><span style="color: hsl(120, 100%, 40%);">+ PAD_GPI(GPIO_135, PULL_UP),</span><br><span> };</span><br><span> </span><br><span> const __attribute__((weak))</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23830">change 23830</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23830"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I24e5091fc7ef696f8e9c932ce04664e6cc3ccb90 </div>
<div style="display:none"> Gerrit-Change-Number: 23830 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Justin TerAvest <teravest@chromium.org> </div>