<p><a href="https://review.coreboot.org/22106">View Change</a></p><p>10 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22106/44/src/security/tpm/tspi/tspi.c">File src/security/tpm/tspi/tspi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22106/44/src/security/tpm/tspi/tspi.c@62">Patch Set #44, Line 62:</a> <code style="font-family:monospace,monospace"> return TPM_E_MUST_REBOOT;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This is changing behavior... the old code just fell through to SUCCESS here. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22106/44/src/security/tpm/tspi/tspi.c@124">Patch Set #44, Line 124:</a> <code style="font-family:monospace,monospace"> if (IS_ENABLED(CONFIG_TPM_DEACTIVATE))</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This should probably go above the enable/activate part below and then directly goto out, otherwise y […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22106/44/src/security/tpm/tspi/tspi.c@148">Patch Set #44, Line 148:</a> <code style="font-family:monospace,monospace">#if IS_ENABLED(CONFIG_TPM1)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Please use […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22106/44/src/security/tpm/tspi/tspi.c@167">Patch Set #44, Line 167:</a> <code style="font-family:monospace,monospace">uint32_t tpm_extend_pcr(int pcr, uint8_t *digest, uint8_t *out_digest)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I'm still really not sure what this function does. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Normally by extending a PCR, a TCPA log is generated as well. I will add more code here in later patches</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22106/44/src/security/tpm/tss/tcg-2.0/tss.c">File src/security/tpm/tss/tcg-2.0/tss.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22106/44/src/security/tpm/tss/tcg-2.0/tss.c@309">Patch Set #44, Line 309:</a> <code style="font-family:monospace,monospace">uint32_t tlcl_define_space(uint32_t space_index, size_t space_size, const TPMA_NV nv_attributes, const uint8_t *nv_policy)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">80 character limit</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22106/44/src/security/tpm/tss/tcg-2.0/tss.c@330">Patch Set #44, Line 330:</a> <code style="font-family:monospace,monospace"> nvds_cmd.publicInfo.attributes = nv_attributes;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It is weird that one of the arguments of the function only applies if the other one is not NULL, and […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22106/44/src/security/tpm/tss/tcg-2.0/tss_structures.h">File src/security/tpm/tss/tcg-2.0/tss_structures.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22106/44/src/security/tpm/tss/tcg-2.0/tss_structures.h@133">Patch Set #44, Line 133:</a> <code style="font-family:monospace,monospace">#define KERNEL_NV_INDEX 0x1008</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Why are these duplicated here? With your changes you shouldn't need them in the TSS code anymore, ri […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">yes, just a leftover. The changes are a way too complex.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22106/44/src/security/vboot/antirollback.h">File src/security/vboot/antirollback.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22106/44/src/security/vboot/antirollback.h@29">Patch Set #44, Line 29:</a> <code style="font-family:monospace,monospace">#define REC_HASH_NV_INDEX 0x100b</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Bad merge? You're just duplicating lines here...</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/22106/44/src/security/vboot/secdata_tpm.c">File src/security/vboot/secdata_tpm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22106/44/src/security/vboot/secdata_tpm.c@196">Patch Set #44, Line 196:</a> <code style="font-family:monospace,monospace"> VB2_SECDATA_SIZE, ro_space_attributes, pcr0_unchanged_policy));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">80 character limit</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22106/44/src/security/vboot/secdata_tpm.c@439">Patch Set #44, Line 439:</a> <code style="font-family:monospace,monospace"> return TPM_SUCCESS;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This will return success on other errors. Just do […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22106">change 22106</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22106"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I883c489801fce88e13952fe24b67315ab6bb1afb </div>
<div style="display:none"> Gerrit-Change-Number: 22106 </div>
<div style="display:none"> Gerrit-PatchSet: 44 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Andrey Pronin <apronin@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Randall Spangler <randall@spanglers.com> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 19 Feb 2018 13:16:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>