<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23760">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/generic/adau7002/adau7002.c: Fix null pointer dereference<br><br>Procedures acpi_device_scope() and acpi_device_name() can under certain<br>conditions return NULL. Check the return before using them.<br><br>This fixes CID 1385944<br>BUG=b:73331544<br>TEST=Build kahlee.<br><br>Change-Id: Ifcdf905100d22a1d828394f8685641eb432bb836<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/drivers/generic/adau7002/adau7002.c<br>1 file changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/23760/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/generic/adau7002/adau7002.c b/src/drivers/generic/adau7002/adau7002.c</span><br><span>index d21d513..1e1acf0 100644</span><br><span>--- a/src/drivers/generic/adau7002/adau7002.c</span><br><span>+++ b/src/drivers/generic/adau7002/adau7002.c</span><br><span>@@ -32,9 +32,14 @@</span><br><span>     if (!dev->enabled)</span><br><span>                return;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   const char *scope = acpi_device_scope(dev);</span><br><span style="color: hsl(120, 100%, 40%);">+   const char *name = acpi_device_name(dev);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (!scope || !name)</span><br><span style="color: hsl(120, 100%, 40%);">+          return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    /* Device */</span><br><span style="color: hsl(0, 100%, 40%);">-    acpigen_write_scope(acpi_device_scope(dev));</span><br><span style="color: hsl(0, 100%, 40%);">-    acpigen_write_device(acpi_device_name(dev));</span><br><span style="color: hsl(120, 100%, 40%);">+  acpigen_write_scope(scope);</span><br><span style="color: hsl(120, 100%, 40%);">+   acpigen_write_device(name);</span><br><span>  acpigen_write_name_string("_HID", ADAU7002_ACPI_HID);</span><br><span>      acpigen_write_name_integer("_UID", 0);</span><br><span>     acpigen_write_name_string("_DDN", dev->chip_ops->name);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23760">change 23760</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23760"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ifcdf905100d22a1d828394f8685641eb432bb836 </div>
<div style="display:none"> Gerrit-Change-Number: 23760 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>