<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23761">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/common/block/s3/s3_resume.c: Check mrc_cache_get_current() return<br><br>Procedure mrc_cache_get_current() returns -1 for error, 0 for pass. Do<br>check the return in procedure get_s3nv_info.<br><br>This fixes CID 1385943<br>BUG=b:73333332<br>TEST=Build kahlee<br><br>Change-Id: I0f6a58380a38d13120e997dcd966423d3c2af091<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/common/block/s3/s3_resume.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/23761/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/common/block/s3/s3_resume.c b/src/soc/amd/common/block/s3/s3_resume.c</span><br><span>index 4883fa5..1ba9468 100644</span><br><span>--- a/src/soc/amd/common/block/s3/s3_resume.c</span><br><span>+++ b/src/soc/amd/common/block/s3/s3_resume.c</span><br><span>@@ -27,7 +27,11 @@</span><br><span> {</span><br><span>  struct region_device rdev;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  mrc_cache_get_current(MRC_TRAINING_DATA, DEFAULT_MRC_VERSION, &rdev);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (mrc_cache_get_current(MRC_TRAINING_DATA, DEFAULT_MRC_VERSION,</span><br><span style="color: hsl(120, 100%, 40%);">+                                     &rdev)) {</span><br><span style="color: hsl(120, 100%, 40%);">+         printk(BIOS_ERR, "mrc_cache_get_current returned error\n");</span><br><span style="color: hsl(120, 100%, 40%);">+         return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span>    *base = rdev_mmap_full(&rdev);</span><br><span>   *size = region_device_sz(&rdev);</span><br><span>         if (!*base || !*size)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23761">change 23761</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23761"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0f6a58380a38d13120e997dcd966423d3c2af091 </div>
<div style="display:none"> Gerrit-Change-Number: 23761 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>