<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23688">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libpayload/drivers/usb: Fix broken retry counter<br><br>Exit on first sucessful CONTROL transfer instead of doing<br>GET_DESCRIPTOR_TRIES iterations.<br><br>Tested on Lenovo T500 using UHCI controller.<br><br>Change-Id: I7c881c08d94636a43223338e46c876b5f3e27d47<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M payloads/libpayload/drivers/usb/usb.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/23688/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/payloads/libpayload/drivers/usb/usb.c b/payloads/libpayload/drivers/usb/usb.c</span><br><span>index bb42f89..906df84 100644</span><br><span>--- a/payloads/libpayload/drivers/usb/usb.c</span><br><span>+++ b/payloads/libpayload/drivers/usb/usb.c</span><br><span>@@ -173,10 +173,11 @@</span><br><span> </span><br><span>               ret = dev->controller->control(dev, IN,</span><br><span>                                sizeof(dr), &dr, len, data);</span><br><span style="color: hsl(0, 100%, 40%);">-                if (ret)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+            if (ret != len)</span><br><span>                      udelay(10);</span><br><span>          else</span><br><span style="color: hsl(0, 100%, 40%);">-                    return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+                     return len;</span><br><span>  }</span><br><span>    return ret;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23688">change 23688</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23688"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I7c881c08d94636a43223338e46c876b5f3e27d47 </div>
<div style="display:none"> Gerrit-Change-Number: 23688 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>