<p><a href="https://review.coreboot.org/23689">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23689/1/payloads/libpayload/drivers/usb/usb.c">File payloads/libpayload/drivers/usb/usb.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23689/1/payloads/libpayload/drivers/usb/usb.c@673">Patch Set #1, Line 673:</a> <code style="font-family:monospace,monospace">        if (dev->descriptor)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No need to check for NULL, free(NULL); is valid.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23689/1/payloads/libpayload/drivers/usb/usb.c@675">Patch Set #1, Line 675:</a> <code style="font-family:monospace,monospace">0</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What's wrong with NULL?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23689/1/payloads/libpayload/drivers/usb/usb.c@673">Patch Set #1, Line 673:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">        if (dev->descriptor)<br>               free(dev->descriptor);<br>     dev->descriptor = 0;<br>       if (dev->configuration)<br>            free(dev->configuration);<br>  dev->configuration = 0;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">IMO, this should be done after the call to ->destroy(). You<br>shouldn't have to repeat it in every implementation...</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23689">change 23689</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23689"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib2d80dd4590aa0dacdf2da3b614c6505c931d0be </div>
<div style="display:none"> Gerrit-Change-Number: 23689 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 10 Feb 2018 14:00:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>