<p>Youness Alaoui has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23684">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">purism/librem_skl: Explicitely enable Intel SpeedStep Technology<br><br>Enabling Intel SpeedStep Technology ensures the ACPI tables contain<br>the C-states/P-states which are required for the xen-acpi-processor<br>module to be loaded. Without it, the Qubes 4.0-rc4 installer will<br>complain at boot about modules that could not be loaded.<br><br>The VMX feature was enabled by default by the FSP but a different<br>FSP might have it disabled, so this ensures that VMX is explicitely<br>enabled for the Librem machines. This option however doesn't seem<br>to work in the FSP since VMX doesn't actually get enabled but as<br>long as the features MSR remains unlocked, it's not critical.<br><br>Change-Id: I968ef36ec9382a10db13d96fd3a5c0fc904db387<br>Signed-off-by: Youness Alaoui <youness.alaoui@puri.sm><br>---<br>M src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/23684/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb b/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb</span><br><span>index e2e2ac0..9ce1d91 100644</span><br><span>--- a/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb</span><br><span>+++ b/src/mainboard/purism/librem_skl/variants/librem13v2/devicetree.cb</span><br><span>@@ -7,6 +7,9 @@</span><br><span>       register "deep_s5_enable_dc" = "0"</span><br><span>       register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN"</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+     register "eist_enable" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+      register "VmxEnable" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     # GPE configuration</span><br><span>  # Note that GPE events called out in ASL code rely on this</span><br><span>   # route. i.e. If this route changes then the affected GPE</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23684">change 23684</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23684"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I968ef36ec9382a10db13d96fd3a5c0fc904db387 </div>
<div style="display:none"> Gerrit-Change-Number: 23684 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Youness Alaoui <snifikino@gmail.com> </div>