<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23673">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/pineview: Get rid off device_t<br><br>Use of `device_t` has been<br>abandoned in ramstage<br><br>Change-Id: Icec2e5f722c1f15493e5861b47f64698250f5813<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/northbridge/intel/pineview/gma.c<br>M src/northbridge/intel/pineview/northbridge.c<br>2 files changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/23673/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c</span><br><span>index d47fc0e..ec332e6 100644</span><br><span>--- a/src/northbridge/intel/pineview/gma.c</span><br><span>+++ b/src/northbridge/intel/pineview/gma.c</span><br><span>@@ -74,7 +74,7 @@</span><br><span> static int gtt_setup(u8 *mmiobase)</span><br><span> {</span><br><span>    u32 gttbase;</span><br><span style="color: hsl(0, 100%, 40%);">-    device_t dev = dev_find_slot(0, PCI_DEVFN(0,0));</span><br><span style="color: hsl(120, 100%, 40%);">+      struct device *dev = dev_find_slot(0, PCI_DEVFN(0,0));</span><br><span> </span><br><span>   gttbase = pci_read_config32(dev, BGSM);</span><br><span>      printk(BIOS_DEBUG, "gttbase = %08x\n", gttbase);</span><br><span>@@ -298,7 +298,7 @@</span><br><span>     intel_gma_restore_opregion();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void gma_set_subsystem(device_t dev, unsigned vendor, unsigned device)</span><br><span style="color: hsl(120, 100%, 40%);">+static void gma_set_subsystem(struct device *dev, unsigned vendor, unsigned device)</span><br><span> {</span><br><span>        if (!vendor || !device) {</span><br><span>            pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,</span><br><span>@@ -312,7 +312,7 @@</span><br><span> </span><br><span> const struct i915_gpu_controller_info *intel_gma_get_controller_info(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   device_t dev = dev_find_slot(0, PCI_DEVFN(0x2,0));</span><br><span style="color: hsl(120, 100%, 40%);">+    struct device *dev = dev_find_slot(0, PCI_DEVFN(0x2,0));</span><br><span>     if (!dev) {</span><br><span>          printk(BIOS_WARNING, "WARNING: Can't find IGD (0,2,0)\n");</span><br><span>             return NULL;</span><br><span>diff --git a/src/northbridge/intel/pineview/northbridge.c b/src/northbridge/intel/pineview/northbridge.c</span><br><span>index ea55974..61b9edb 100644</span><br><span>--- a/src/northbridge/intel/pineview/northbridge.c</span><br><span>+++ b/src/northbridge/intel/pineview/northbridge.c</span><br><span>@@ -35,7 +35,7 @@</span><br><span>  */</span><br><span> static const int legacy_hole_base_k = 0xa0000 / 1024;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void add_fixed_resources(device_t dev, int index)</span><br><span style="color: hsl(120, 100%, 40%);">+static void add_fixed_resources(struct device *dev, int index)</span><br><span> {</span><br><span>       struct resource *resource;</span><br><span> </span><br><span>@@ -51,7 +51,7 @@</span><br><span>                   (0x100000 - 0xc0000) >> 10);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void mch_domain_read_resources(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mch_domain_read_resources(struct device *dev)</span><br><span> {</span><br><span>       u64 tom, touud;</span><br><span>      u32 tomk, tolud, tseg_sizek;</span><br><span>@@ -127,7 +127,7 @@</span><br><span>   add_fixed_resources(dev, index);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void mch_domain_set_resources(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mch_domain_set_resources(struct device *dev)</span><br><span> {</span><br><span>   struct resource *res;</span><br><span> </span><br><span>@@ -137,7 +137,7 @@</span><br><span>      assign_resources(dev->link_list);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void mch_domain_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void mch_domain_init(struct device *dev)</span><br><span> {</span><br><span>         u32 reg32;</span><br><span> </span><br><span>@@ -156,7 +156,7 @@</span><br><span>         .acpi_fill_ssdt_generator = generate_cpu_entries,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void cpu_bus_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void cpu_bus_init(struct device *dev)</span><br><span> {</span><br><span>         initialize_cpus(dev->link_list);</span><br><span> }</span><br><span>@@ -169,7 +169,7 @@</span><br><span> };</span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void enable_dev(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void enable_dev(struct device *dev)</span><br><span> {</span><br><span>    /* Set the operations if it is a special bus type */</span><br><span>         if (dev->path.type == DEVICE_PATH_DOMAIN) {</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23673">change 23673</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23673"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icec2e5f722c1f15493e5861b47f64698250f5813 </div>
<div style="display:none"> Gerrit-Change-Number: 23673 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>