<p>Daniel Kurtz would like Daniel Kurtz to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/23657">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/i2c/da7219: Allow GPIO based interrupt<br><br>Allow specifying the DA7219 interrupt pin as either an Interrupt or<br>GpioInt.<br><br>BUG=b:72121803<br>TEST=(with whole patch series) Grunt Kernel discovers DA7219 on i2c0<br><br>Change-Id: I2d26731bf4c0ad590dad2c5d26c252371f415f9a<br>Signed-off-by: Daniel Kurtz <djkurtz@chromium.org><br>---<br>M src/drivers/i2c/da7219/chip.h<br>M src/drivers/i2c/da7219/da7219.c<br>2 files changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/23657/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/i2c/da7219/chip.h b/src/drivers/i2c/da7219/chip.h</span><br><span>index 823b940..572d727 100644</span><br><span>--- a/src/drivers/i2c/da7219/chip.h</span><br><span>+++ b/src/drivers/i2c/da7219/chip.h</span><br><span>@@ -8,6 +8,9 @@</span><br><span>        /* Interrupt configuration */</span><br><span>        struct acpi_irq irq;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      /* Use GPIO based interrupt instead of PIRQ */</span><br><span style="color: hsl(120, 100%, 40%);">+        struct acpi_gpio irq_gpio;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         /* I2C Bus Frequency in Hertz (default 400kHz) */</span><br><span>    unsigned bus_speed;</span><br><span> </span><br><span>diff --git a/src/drivers/i2c/da7219/da7219.c b/src/drivers/i2c/da7219/da7219.c</span><br><span>index 4eef00c..c0f152d 100644</span><br><span>--- a/src/drivers/i2c/da7219/da7219.c</span><br><span>+++ b/src/drivers/i2c/da7219/da7219.c</span><br><span>@@ -57,7 +57,11 @@</span><br><span>        acpigen_write_name("_CRS");</span><br><span>        acpigen_write_resourcetemplate_header();</span><br><span>     acpi_device_write_i2c(&i2c);</span><br><span style="color: hsl(0, 100%, 40%);">-        acpi_device_write_interrupt(&config->irq);</span><br><span style="color: hsl(120, 100%, 40%);">+     /* Use either Interrupt() or GpioInt() */</span><br><span style="color: hsl(120, 100%, 40%);">+     if (config->irq_gpio.pin_count)</span><br><span style="color: hsl(120, 100%, 40%);">+            acpi_device_write_gpio(&config->irq_gpio);</span><br><span style="color: hsl(120, 100%, 40%);">+     else</span><br><span style="color: hsl(120, 100%, 40%);">+          acpi_device_write_interrupt(&config->irq);</span><br><span>    acpigen_write_resourcetemplate_footer();</span><br><span> </span><br><span>         /* AAD Child Device Properties */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23657">change 23657</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23657"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2d26731bf4c0ad590dad2c5d26c252371f415f9a </div>
<div style="display:none"> Gerrit-Change-Number: 23657 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Daniel Kurtz <djkurtz@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal@amd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Daniel Kurtz <djkurtz@chromium.org> </div>