<p><a href="https://review.coreboot.org/23662">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/romstage.c">File src/mainboard/kontron/986lcd-m/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/romstage.c@221">Patch Set #4, Line 221:</a> <code style="font-family:monospace,monospace">    reg32 |= 1;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Drop?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">not sure if this needs to be done on each FD write or once. anyway follow-up patch will move this to ramstage...</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c">File src/southbridge/intel/i82801gx/i82801gx.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@43">Patch Set #4, Line 43:</a> <code style="font-family:monospace,monospace">BIOS_INFO,</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It's not that bad, is it?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">leftover from i82801ix which dies here</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23662">change 23662</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23662"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 </div>
<div style="display:none"> Gerrit-Change-Number: 23662 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 08 Feb 2018 22:16:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>