<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23652">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/cpu: Don't hide pointers behind typedefs<br><br>See Change 7146<br><br>Change-Id: I17675b004023453f137abd387cfacd308d9b98b5<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/cpu/intel/fsp_model_206ax/acpi.c<br>M src/cpu/intel/fsp_model_406dx/acpi.c<br>M src/cpu/intel/haswell/acpi.c<br>M src/cpu/intel/haswell/smmrelocate.c<br>M src/cpu/intel/model_2065x/acpi.c<br>M src/cpu/intel/model_206ax/acpi.c<br>M src/cpu/intel/speedstep/acpi.c<br>7 files changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/23652/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/cpu/intel/fsp_model_206ax/acpi.c b/src/cpu/intel/fsp_model_206ax/acpi.c</span><br><span>index 6bf30e1..a10c91b 100644</span><br><span>--- a/src/cpu/intel/fsp_model_206ax/acpi.c</span><br><span>+++ b/src/cpu/intel/fsp_model_206ax/acpi.c</span><br><span>@@ -298,7 +298,7 @@</span><br><span> acpigen_pop_len();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void generate_cpu_entries(device_t device)</span><br><span style="color: hsl(120, 100%, 40%);">+void generate_cpu_entries(struct device *device)</span><br><span> {</span><br><span> int coreID, cpuID, pcontrol_blk = PMB0_BASE, plen = 6;</span><br><span> int totalcores = dev_count_cpu();</span><br><span>diff --git a/src/cpu/intel/fsp_model_406dx/acpi.c b/src/cpu/intel/fsp_model_406dx/acpi.c</span><br><span>index 2124386..80a56c0 100644</span><br><span>--- a/src/cpu/intel/fsp_model_406dx/acpi.c</span><br><span>+++ b/src/cpu/intel/fsp_model_406dx/acpi.c</span><br><span>@@ -259,7 +259,7 @@</span><br><span> acpigen_pop_len();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void generate_cpu_entries(device_t device)</span><br><span style="color: hsl(120, 100%, 40%);">+void generate_cpu_entries(struct device *device)</span><br><span> {</span><br><span> int coreID, cpuID, pcontrol_blk = PMB0_BASE, plen = 6;</span><br><span> int totalcores = dev_count_cpu();</span><br><span>diff --git a/src/cpu/intel/haswell/acpi.c b/src/cpu/intel/haswell/acpi.c</span><br><span>index 74d8fba..40279bf 100644</span><br><span>--- a/src/cpu/intel/haswell/acpi.c</span><br><span>+++ b/src/cpu/intel/haswell/acpi.c</span><br><span>@@ -303,7 +303,7 @@</span><br><span> acpigen_pop_len();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void generate_cpu_entries(device_t device)</span><br><span style="color: hsl(120, 100%, 40%);">+void generate_cpu_entries(struct device *device)</span><br><span> {</span><br><span> int coreID, cpuID, pcontrol_blk = get_pmbase(), plen = 6;</span><br><span> int totalcores = dev_count_cpu();</span><br><span>diff --git a/src/cpu/intel/haswell/smmrelocate.c b/src/cpu/intel/haswell/smmrelocate.c</span><br><span>index 8d9a4dc..d680497 100644</span><br><span>--- a/src/cpu/intel/haswell/smmrelocate.c</span><br><span>+++ b/src/cpu/intel/haswell/smmrelocate.c</span><br><span>@@ -308,7 +308,7 @@</span><br><span> void smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,</span><br><span> size_t *smm_save_state_size)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev = dev_find_slot(0, PCI_DEVFN(0, 0));</span><br><span style="color: hsl(120, 100%, 40%);">+ device dev = dev_find_slot(0, PCI_DEVFN(0, 0));</span><br><span> </span><br><span> printk(BIOS_DEBUG, "Setting up SMI for CPU\n");</span><br><span> </span><br><span>diff --git a/src/cpu/intel/model_2065x/acpi.c b/src/cpu/intel/model_2065x/acpi.c</span><br><span>index e64405ac..7de8b19 100644</span><br><span>--- a/src/cpu/intel/model_2065x/acpi.c</span><br><span>+++ b/src/cpu/intel/model_2065x/acpi.c</span><br><span>@@ -295,7 +295,7 @@</span><br><span> acpigen_pop_len();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void generate_cpu_entries(device_t device)</span><br><span style="color: hsl(120, 100%, 40%);">+void generate_cpu_entries(struct device *device)</span><br><span> {</span><br><span> int coreID, cpuID, pcontrol_blk = PMB0_BASE, plen = 6;</span><br><span> int totalcores = dev_count_cpu();</span><br><span>diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c</span><br><span>index 33c4212..8e2c0d1 100644</span><br><span>--- a/src/cpu/intel/model_206ax/acpi.c</span><br><span>+++ b/src/cpu/intel/model_206ax/acpi.c</span><br><span>@@ -298,7 +298,7 @@</span><br><span> acpigen_pop_len();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void generate_cpu_entries(device_t device)</span><br><span style="color: hsl(120, 100%, 40%);">+void generate_cpu_entries(struct device *device)</span><br><span> {</span><br><span> int coreID, cpuID, pcontrol_blk = PMB0_BASE, plen = 6;</span><br><span> int totalcores = dev_count_cpu();</span><br><span>diff --git a/src/cpu/intel/speedstep/acpi.c b/src/cpu/intel/speedstep/acpi.c</span><br><span>index 73b7431..0feaa2f 100644</span><br><span>--- a/src/cpu/intel/speedstep/acpi.c</span><br><span>+++ b/src/cpu/intel/speedstep/acpi.c</span><br><span>@@ -113,7 +113,7 @@</span><br><span> /**</span><br><span> * @brief Generate ACPI entries for Speedstep for each cpu</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-void generate_cpu_entries(device_t device)</span><br><span style="color: hsl(120, 100%, 40%);">+void generate_cpu_entries(struct device *device)</span><br><span> {</span><br><span> int coreID, cpuID, pcontrol_blk = PMB0_BASE, plen = 6;</span><br><span> int totalcores = determine_total_number_of_cores();</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23652">change 23652</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23652"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I17675b004023453f137abd387cfacd308d9b98b5 </div>
<div style="display:none"> Gerrit-Change-Number: 23652 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>