<p><a href="https://review.coreboot.org/23648">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23648/1/src/mainboard/google/poppy/variants/nautilus/nhlt.c">File src/mainboard/google/poppy/variants/nautilus/nhlt.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23648/1/src/mainboard/google/poppy/variants/nautilus/nhlt.c@37">Patch Set #1, Line 37:</a> <code style="font-family:monospace,monospace">__attribute__((weak))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This shouldn't be a weak function.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23648">change 23648</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23648"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I041f2838f07a2525be7a28fdc69b7f1af46d16f1 </div>
<div style="display:none"> Gerrit-Change-Number: 23648 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Naveen Manohar <naveen.m@intel.com> </div>
<div style="display:none"> Gerrit-Assignee: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 08 Feb 2018 04:39:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>