<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23653">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/cpu/amd: Don't hide pointers behind typedefs<br><br>See Change 7146<br><br>Change-Id: I4b930a191130941c8349861cdd803a5be4219274<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/cpu/amd/agesa/family12/model_12_init.c<br>M src/cpu/amd/agesa/family14/model_14_init.c<br>M src/cpu/amd/agesa/family15tn/model_15_init.c<br>M src/cpu/amd/agesa/family16kb/model_16_init.c<br>M src/cpu/amd/dualcore/amd_sibling.c<br>M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c<br>M src/cpu/amd/family_10h-family_15h/processor_name.c<br>M src/cpu/amd/family_10h-family_15h/ram_calc.c<br>M src/cpu/amd/geode_lx/geode_lx_init.c<br>M src/cpu/amd/model_fxx/model_fxx_init.c<br>M src/cpu/amd/pi/00630F01/model_15_init.c<br>M src/cpu/amd/pi/00660F01/model_15_init.c<br>M src/cpu/amd/pi/00730F01/model_16_init.c<br>13 files changed, 20 insertions(+), 19 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/23653/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/cpu/amd/agesa/family12/model_12_init.c b/src/cpu/amd/agesa/family12/model_12_init.c</span><br><span>index 1d414a2..f96ad9e 100644</span><br><span>--- a/src/cpu/amd/agesa/family12/model_12_init.c</span><br><span>+++ b/src/cpu/amd/agesa/family12/model_12_init.c</span><br><span>@@ -31,7 +31,7 @@</span><br><span> </span><br><span> #define MCI_STATUS 0x401</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void model_12_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void model_12_init(struct device *dev)</span><br><span> {</span><br><span> printk(BIOS_DEBUG, "Model 12 Init.\n");</span><br><span> </span><br><span>diff --git a/src/cpu/amd/agesa/family14/model_14_init.c b/src/cpu/amd/agesa/family14/model_14_init.c</span><br><span>index a03516d..7fce24f 100644</span><br><span>--- a/src/cpu/amd/agesa/family14/model_14_init.c</span><br><span>+++ b/src/cpu/amd/agesa/family14/model_14_init.c</span><br><span>@@ -32,7 +32,7 @@</span><br><span> </span><br><span> #define MCI_STATUS 0x401</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void model_14_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void model_14_init(struct device *dev)</span><br><span> {</span><br><span> u8 i;</span><br><span> msr_t msr;</span><br><span>diff --git a/src/cpu/amd/agesa/family15tn/model_15_init.c b/src/cpu/amd/agesa/family15tn/model_15_init.c</span><br><span>index e0bff4f..433a331 100644</span><br><span>--- a/src/cpu/amd/agesa/family15tn/model_15_init.c</span><br><span>+++ b/src/cpu/amd/agesa/family15tn/model_15_init.c</span><br><span>@@ -31,7 +31,7 @@</span><br><span> #include <arch/acpi.h></span><br><span> #include <northbridge/amd/agesa/agesa_helper.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void model_15_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void model_15_init(struct device *dev)</span><br><span> {</span><br><span> printk(BIOS_DEBUG, "Model 15 Init.\n");</span><br><span> </span><br><span>diff --git a/src/cpu/amd/agesa/family16kb/model_16_init.c b/src/cpu/amd/agesa/family16kb/model_16_init.c</span><br><span>index d49216a..5c8684b 100644</span><br><span>--- a/src/cpu/amd/agesa/family16kb/model_16_init.c</span><br><span>+++ b/src/cpu/amd/agesa/family16kb/model_16_init.c</span><br><span>@@ -30,7 +30,7 @@</span><br><span> #include <arch/acpi.h></span><br><span> #include <northbridge/amd/agesa/agesa_helper.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void model_16_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void model_16_init(struct device *dev)</span><br><span> {</span><br><span> printk(BIOS_DEBUG, "Model 16 Init.\n");</span><br><span> </span><br><span>diff --git a/src/cpu/amd/dualcore/amd_sibling.c b/src/cpu/amd/dualcore/amd_sibling.c</span><br><span>index 693ceb8..f45da6a 100644</span><br><span>--- a/src/cpu/amd/dualcore/amd_sibling.c</span><br><span>+++ b/src/cpu/amd/dualcore/amd_sibling.c</span><br><span>@@ -32,7 +32,7 @@</span><br><span> </span><br><span> static int get_max_siblings(int nodes)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ strcut device *dev;</span><br><span> int nodeid;</span><br><span> int siblings=0;</span><br><span> </span><br><span>@@ -51,7 +51,7 @@</span><br><span> </span><br><span> static void enable_apic_ext_id(int nodes)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> int nodeid;</span><br><span> </span><br><span> //enable APIC_EXIT_ID all the nodes</span><br><span>@@ -67,7 +67,7 @@</span><br><span> </span><br><span> unsigned get_apicid_base(unsigned ioapic_num)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> int nodes;</span><br><span> unsigned apicid_base;</span><br><span> int siblings;</span><br><span>diff --git a/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c b/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c</span><br><span>index f73ce03..0b7ddc6 100644</span><br><span>--- a/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c</span><br><span>+++ b/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c</span><br><span>@@ -59,7 +59,7 @@</span><br><span> </span><br><span> static volatile uint8_t fam15h_startup_flags[MAX_NODES_SUPPORTED][MAX_CORES_SUPPORTED] = {{ 0 }};</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void model_10xxx_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void model_10xxx_init(struct device *dev)</span><br><span> {</span><br><span> u8 i;</span><br><span> msr_t msr;</span><br><span>diff --git a/src/cpu/amd/family_10h-family_15h/processor_name.c b/src/cpu/amd/family_10h-family_15h/processor_name.c</span><br><span>index bda8409..857ea02 100644</span><br><span>--- a/src/cpu/amd/family_10h-family_15h/processor_name.c</span><br><span>+++ b/src/cpu/amd/family_10h-family_15h/processor_name.c</span><br><span>@@ -236,7 +236,8 @@</span><br><span> if (fam15h) {</span><br><span> /* Family 15h or later */</span><br><span> uint32_t dword;</span><br><span style="color: hsl(0, 100%, 40%);">- device_t cpu_fn5_dev = dev_find_slot(0, PCI_DEVFN(0x18, 5));</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *cpu_fn5_dev</span><br><span style="color: hsl(120, 100%, 40%);">+ cpu_fn5_dev = dev_find_slot(0, PCI_DEVFN(0x18, 5));</span><br><span> pci_write_config32(cpu_fn5_dev, 0x194, 0);</span><br><span> dword = pci_read_config32(cpu_fn5_dev, 0x198);</span><br><span> if (dword == 0) {</span><br><span>diff --git a/src/cpu/amd/family_10h-family_15h/ram_calc.c b/src/cpu/amd/family_10h-family_15h/ram_calc.c</span><br><span>index 62b7da3..16caad4 100644</span><br><span>--- a/src/cpu/amd/family_10h-family_15h/ram_calc.c</span><br><span>+++ b/src/cpu/amd/family_10h-family_15h/ram_calc.c</span><br><span>@@ -62,8 +62,8 @@</span><br><span> uint64_t get_cc6_memory_size()</span><br><span> {</span><br><span> uint8_t enable_cc6;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> uint64_t cc6_size = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dct_dev;</span><br><span> </span><br><span> if (is_fam15h()) {</span><br><span> enable_cc6 = 0;</span><br><span>@@ -72,7 +72,7 @@</span><br><span> if (pci_read_config32(PCI_DEV(0, 0x18, 2), 0x118) & (0x1 << 18))</span><br><span> enable_cc6 = 1;</span><br><span> #else</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dct_dev = dev_find_slot(0, PCI_DEVFN(0x18, 2));</span><br><span style="color: hsl(120, 100%, 40%);">+ dct_dev = dev_find_slot(0, PCI_DEVFN(0x18, 2));</span><br><span> if (pci_read_config32(dct_dev, 0x118) & (0x1 << 18))</span><br><span> enable_cc6 = 1;</span><br><span> #endif</span><br><span>diff --git a/src/cpu/amd/geode_lx/geode_lx_init.c b/src/cpu/amd/geode_lx/geode_lx_init.c</span><br><span>index 8c0cef3..e620131 100644</span><br><span>--- a/src/cpu/amd/geode_lx/geode_lx_init.c</span><br><span>+++ b/src/cpu/amd/geode_lx/geode_lx_init.c</span><br><span>@@ -33,7 +33,7 @@</span><br><span> ".byte 0x0f, 0x38\n" "pop %ax\n");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void geode_lx_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void geode_lx_init(struct device *dev)</span><br><span> {</span><br><span> printk(BIOS_DEBUG, "geode_lx_init\n");</span><br><span> </span><br><span>diff --git a/src/cpu/amd/model_fxx/model_fxx_init.c b/src/cpu/amd/model_fxx/model_fxx_init.c</span><br><span>index f5a6773..21e59de 100644</span><br><span>--- a/src/cpu/amd/model_fxx/model_fxx_init.c</span><br><span>+++ b/src/cpu/amd/model_fxx/model_fxx_init.c</span><br><span>@@ -65,7 +65,7 @@</span><br><span> return !is_cpu_pre_e0();</span><br><span> }</span><br><span> // d0 will be treated as e0 with this methods, but the d0 nb_cfg_54 always 0</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *dev;</span><br><span> dev = dev_find_slot(0, PCI_DEVFN(0x18 + nodeid, 2));</span><br><span> if (!dev)</span><br><span> return 0;</span><br><span>@@ -85,7 +85,7 @@</span><br><span> int is_cpu_f0_in_bsp(int nodeid)</span><br><span> {</span><br><span> uint32_t dword;</span><br><span style="color: hsl(0, 100%, 40%);">- device_t dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ strcut device *dev;</span><br><span> </span><br><span> if (!IS_ENABLED(CONFIG_K8_REV_F_SUPPORT))</span><br><span> return 0;</span><br><span>@@ -243,7 +243,7 @@</span><br><span> unsigned long basek;</span><br><span> struct mtrr_state mtrr_state;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- device_t f1_dev, f2_dev, f3_dev;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct device *f1_dev, *f2_dev, *f3_dev;</span><br><span> int enable_scrubbing;</span><br><span> uint32_t dcl;</span><br><span> </span><br><span>@@ -463,7 +463,7 @@</span><br><span> wrmsr(HWCR_MSR, msr);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void model_fxx_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void model_fxx_init(struct device *dev)</span><br><span> {</span><br><span> unsigned long i;</span><br><span> msr_t msr;</span><br><span>diff --git a/src/cpu/amd/pi/00630F01/model_15_init.c b/src/cpu/amd/pi/00630F01/model_15_init.c</span><br><span>index 5299dca..6c3e594 100644</span><br><span>--- a/src/cpu/amd/pi/00630F01/model_15_init.c</span><br><span>+++ b/src/cpu/amd/pi/00630F01/model_15_init.c</span><br><span>@@ -31,7 +31,7 @@</span><br><span> #include <cpu/amd/amdfam15.h></span><br><span> #include <arch/acpi.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void model_15_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void model_15_init(struct device *dev)</span><br><span> {</span><br><span> printk(BIOS_DEBUG, "Model 15 Init.\n");</span><br><span> </span><br><span>diff --git a/src/cpu/amd/pi/00660F01/model_15_init.c b/src/cpu/amd/pi/00660F01/model_15_init.c</span><br><span>index abe20c3..8a8a0a7 100644</span><br><span>--- a/src/cpu/amd/pi/00660F01/model_15_init.c</span><br><span>+++ b/src/cpu/amd/pi/00660F01/model_15_init.c</span><br><span>@@ -47,7 +47,7 @@</span><br><span> LibAmdMsrRead(0xC00110A2, &Tmp64, NULL);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void model_15_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void model_15_init(struct device *dev)</span><br><span> {</span><br><span> printk(BIOS_DEBUG, "Model 15 Init.\n");</span><br><span> </span><br><span>diff --git a/src/cpu/amd/pi/00730F01/model_16_init.c b/src/cpu/amd/pi/00730F01/model_16_init.c</span><br><span>index e0eca94..25cb5dc 100644</span><br><span>--- a/src/cpu/amd/pi/00730F01/model_16_init.c</span><br><span>+++ b/src/cpu/amd/pi/00730F01/model_16_init.c</span><br><span>@@ -30,7 +30,7 @@</span><br><span> #include <cpu/amd/amdfam16.h></span><br><span> #include <arch/acpi.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static void model_16_init(device_t dev)</span><br><span style="color: hsl(120, 100%, 40%);">+static void model_16_init(struct device *dev)</span><br><span> {</span><br><span> printk(BIOS_DEBUG, "Model 16 Init.\n");</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23653">change 23653</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23653"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4b930a191130941c8349861cdd803a5be4219274 </div>
<div style="display:none"> Gerrit-Change-Number: 23653 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>