<p>Nico Huber has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23637">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[WIP] gfx_test: Refactor "bored" loop<br><br>Change-Id: I44920c35b4ea3f0a08ce306dcf8203379c15791b<br>Signed-off-by: Nico Huber <nico.h@gmx.de><br>---<br>M gfxtest/hw-gfx-gma-gfx_test.adb<br>1 file changed, 25 insertions(+), 21 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/37/23637/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb</span><br><span>index 231d5dd..0c29fbe 100644</span><br><span>--- a/gfxtest/hw-gfx-gma-gfx_test.adb</span><br><span>+++ b/gfxtest/hw-gfx-gma-gfx_test.adb</span><br><span>@@ -465,9 +465,11 @@</span><br><span> end loop;</span><br><span> end loop;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if Delay_S > 8 then -- getting bored?</span><br><span style="color: hsl(120, 100%, 40%);">+ if Delay_S >= 12 then -- getting bored?</span><br><span style="color: hsl(120, 100%, 40%);">+ Time.M_Delay (8_000);</span><br><span style="color: hsl(120, 100%, 40%);">+ Delay_S := Delay_S - 8;</span><br><span> declare</span><br><span style="color: hsl(0, 100%, 40%);">- New_Pipes : GMA.Pipe_Configs;</span><br><span style="color: hsl(120, 100%, 40%);">+ New_Pipes : GMA.Pipe_Configs := Pipes;</span><br><span> </span><br><span> function Rand_Div (Num : Pos_Type) return Pos_Type is</span><br><span> (case Rand mod 4 is</span><br><span>@@ -476,30 +478,32 @@</span><br><span> when 1 => Rand mod Num,</span><br><span> when others => 0);</span><br><span> begin</span><br><span style="color: hsl(0, 100%, 40%);">- Time.M_Delay (4_000);</span><br><span style="color: hsl(0, 100%, 40%);">- Delay_S := Delay_S - 4;</span><br><span style="color: hsl(0, 100%, 40%);">- while Delay_S > 4 loop</span><br><span style="color: hsl(0, 100%, 40%);">- Time.M_Delay (4_000);</span><br><span style="color: hsl(0, 100%, 40%);">- Delay_S := Delay_S - 4;</span><br><span style="color: hsl(120, 100%, 40%);">+ while Delay_S >= 4 loop</span><br><span> New_Pipes := Pipes;</span><br><span> for Pipe in GMA.Pipe_Index loop</span><br><span style="color: hsl(0, 100%, 40%);">- New_Pipes (Pipe).Framebuffer.Start_X :=</span><br><span style="color: hsl(0, 100%, 40%);">- Rand_Div (Pipes (Pipe).Framebuffer.Width);</span><br><span style="color: hsl(0, 100%, 40%);">- New_Pipes (Pipe).Framebuffer.Start_Y :=</span><br><span style="color: hsl(0, 100%, 40%);">- Rand_Div (Pipes (Pipe).Framebuffer.Height);</span><br><span style="color: hsl(0, 100%, 40%);">- New_Pipes (Pipe).Framebuffer.Width :=</span><br><span style="color: hsl(0, 100%, 40%);">- Width_Type'Max (320,</span><br><span style="color: hsl(0, 100%, 40%);">- Pipes (Pipe).Framebuffer.Width</span><br><span style="color: hsl(0, 100%, 40%);">- - New_Pipes (Pipe).Framebuffer.Start_X</span><br><span style="color: hsl(0, 100%, 40%);">- - Rand_Div (Pipes (Pipe).Framebuffer.Width));</span><br><span style="color: hsl(0, 100%, 40%);">- New_Pipes (Pipe).Framebuffer.Height :=</span><br><span style="color: hsl(0, 100%, 40%);">- Height_Type'Max (320,</span><br><span style="color: hsl(0, 100%, 40%);">- Pipes (Pipe).Framebuffer.Height</span><br><span style="color: hsl(0, 100%, 40%);">- - New_Pipes (Pipe).Framebuffer.Start_Y</span><br><span style="color: hsl(0, 100%, 40%);">- - Rand_Div (Pipes (Pipe).Framebuffer.Height));</span><br><span style="color: hsl(120, 100%, 40%);">+ exit when Pipes (Pipe).Port = Disabled;</span><br><span style="color: hsl(120, 100%, 40%);">+ declare</span><br><span style="color: hsl(120, 100%, 40%);">+ New_FB : Framebuffer_Type renames</span><br><span style="color: hsl(120, 100%, 40%);">+ New_Pipes (Pipe).Framebuffer;</span><br><span style="color: hsl(120, 100%, 40%);">+ Width : constant Width_Type :=</span><br><span style="color: hsl(120, 100%, 40%);">+ Pipes (Pipe).Framebuffer.Width;</span><br><span style="color: hsl(120, 100%, 40%);">+ Height : constant Height_Type :=</span><br><span style="color: hsl(120, 100%, 40%);">+ Pipes (Pipe).Framebuffer.Height;</span><br><span style="color: hsl(120, 100%, 40%);">+ begin</span><br><span style="color: hsl(120, 100%, 40%);">+ New_FB.Start_X := Pos_Type'Min</span><br><span style="color: hsl(120, 100%, 40%);">+ (Width - 320, Rand_Div (Width));</span><br><span style="color: hsl(120, 100%, 40%);">+ New_FB.Start_Y := Pos_Type'Min</span><br><span style="color: hsl(120, 100%, 40%);">+ (Height - 320, Rand_Div (Height));</span><br><span style="color: hsl(120, 100%, 40%);">+ New_FB.Width := Width_Type'Max</span><br><span style="color: hsl(120, 100%, 40%);">+ (320, Width - New_FB.Start_X - Rand_Div (Width));</span><br><span style="color: hsl(120, 100%, 40%);">+ New_FB.Height := Height_Type'Max</span><br><span style="color: hsl(120, 100%, 40%);">+ (320, Height - New_FB.Start_Y - Rand_Div (Height));</span><br><span style="color: hsl(120, 100%, 40%);">+ end;</span><br><span> end loop;</span><br><span> GMA.Dump_Configs (New_Pipes);</span><br><span> GMA.Update_Outputs (New_Pipes);</span><br><span style="color: hsl(120, 100%, 40%);">+ Time.M_Delay (4_000);</span><br><span style="color: hsl(120, 100%, 40%);">+ Delay_S := Delay_S - 4;</span><br><span> end loop;</span><br><span> end;</span><br><span> end if;</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23637">change 23637</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23637"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libgfxinit </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I44920c35b4ea3f0a08ce306dcf8203379c15791b </div>
<div style="display:none"> Gerrit-Change-Number: 23637 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>