<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23636">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Clean up SMBIOS Table Type 17 creation<br><br>Clean up skylake/kabylake SMBIOS Type 17 table as per Cannonlake<br>review feedback.<br><br>Change-Id: I6ad99de53e280a3db431f706310e6cb22b8b3953<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/skylake/romstage/romstage_fsp20.c<br>1 file changed, 11 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/23636/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/romstage/romstage_fsp20.c b/src/soc/intel/skylake/romstage/romstage_fsp20.c</span><br><span>index d4606a4..98c78a5 100644</span><br><span>--- a/src/soc/intel/skylake/romstage/romstage_fsp20.c</span><br><span>+++ b/src/soc/intel/skylake/romstage/romstage_fsp20.c</span><br><span>@@ -44,6 +44,13 @@</span><br><span>  0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23  \</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Memory Channel Present Status */</span><br><span style="color: hsl(120, 100%, 40%);">+enum {</span><br><span style="color: hsl(120, 100%, 40%);">+       CHANNEL_NOT_PRESENT,</span><br><span style="color: hsl(120, 100%, 40%);">+  CHANNEL_DISABLED,</span><br><span style="color: hsl(120, 100%, 40%);">+     CHANNEL_PRESENT</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Save the DIMM information for SMBIOS table 17 */</span><br><span> static void save_dimm_info(void)</span><br><span> {</span><br><span>@@ -56,13 +63,14 @@</span><br><span>  struct dimm_info *dest_dimm;</span><br><span>         struct memory_info *mem_info;</span><br><span>        const MEMORY_INFO_DATA_HOB *memory_info_hob;</span><br><span style="color: hsl(0, 100%, 40%);">-    const uint8_t smbios_memory_info_guid[16] = FSP_SMBIOS_MEMORY_INFO_GUID;</span><br><span style="color: hsl(120, 100%, 40%);">+      const uint8_t smbios_memory_info_guid[16] =</span><br><span style="color: hsl(120, 100%, 40%);">+                   FSP_SMBIOS_MEMORY_INFO_GUID;</span><br><span> </span><br><span>     /* Locate the memory info HOB, presence validated by raminit */</span><br><span>      memory_info_hob =</span><br><span>            fsp_find_extension_hob_by_guid(smbios_memory_info_guid,</span><br><span>                                              &hob_size);</span><br><span style="color: hsl(0, 100%, 40%);">- if (memory_info_hob == NULL) {</span><br><span style="color: hsl(120, 100%, 40%);">+        if (memory_info_hob == NULL || hob_size == 0) {</span><br><span>              printk(BIOS_ERR, "SMBIOS MEMORY_INFO_DATA_HOB not found\n");</span><br><span>               return;</span><br><span>      }</span><br><span>@@ -84,7 +92,7 @@</span><br><span>        ctrlr_info = &memory_info_hob->Controller[0];</span><br><span>         for (channel = 0; channel < MAX_CH && index < dimm_max; channel++) {</span><br><span>           channel_info = &ctrlr_info->ChannelInfo[channel];</span><br><span style="color: hsl(0, 100%, 40%);">-                if (channel_info->Status != 2)</span><br><span style="color: hsl(120, 100%, 40%);">+             if (channel_info->Status != CHANNEL_PRESENT)</span><br><span>                      continue;</span><br><span>            for (dimm = 0; dimm < MAX_DIMM && index < dimm_max; dimm++) {</span><br><span>                  src_dimm = &channel_info->DimmInfo[dimm];</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23636">change 23636</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23636"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6ad99de53e280a3db431f706310e6cb22b8b3953 </div>
<div style="display:none"> Gerrit-Change-Number: 23636 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>