<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23639">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">payloads: Add an option to compress secondary payloads<br><br>Both grub and SeaBIOS can chainload lzma compressed<br>payloads. Therefore it is beneficiary to compress secondary payloads<br>like memtest86+, coreinfo, nvramcui,... for both size reasons and<br>often also speed reasons since the limiting factor is generally the<br>IO of the boot device.<br><br>Tested with SeaBIOS and memtest86+ master on Thinkpad X220.<br><br>Change-Id: Iddfd6fcf4112d255cc7b2b49b99bf5ea4d6f8db4<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M Makefile.inc<br>M payloads/Kconfig<br>M payloads/Makefile.inc<br>M payloads/external/Makefile.inc<br>4 files changed, 16 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/23639/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Makefile.inc b/Makefile.inc</span><br><span>index 0593d31..379215b 100644</span><br><span>--- a/Makefile.inc</span><br><span>+++ b/Makefile.inc</span><br><span>@@ -350,6 +350,11 @@</span><br><span> CBFS_PAYLOAD_COMPRESS_FLAG:=LZ4</span><br><span> endif</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG:=none</span><br><span style="color: hsl(120, 100%, 40%);">+ifeq ($(CONFIG_COMPRESS_SECONDARY_PAYLOAD),y)</span><br><span style="color: hsl(120, 100%, 40%);">+CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG:=LZMA</span><br><span style="color: hsl(120, 100%, 40%);">+endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> CBFS_PRERAM_COMPRESS_FLAG:=none</span><br><span> ifeq ($(CONFIG_COMPRESS_PRERAM_STAGES),y)</span><br><span> CBFS_PRERAM_COMPRESS_FLAG:=LZ4</span><br><span>diff --git a/payloads/Kconfig b/payloads/Kconfig</span><br><span>index 125ca61..4dd733f 100644</span><br><span>--- a/payloads/Kconfig</span><br><span>+++ b/payloads/Kconfig</span><br><span>@@ -82,6 +82,13 @@</span><br><span> Add the payload to cbfs as a flat binary type instead of as an</span><br><span> elf payload</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+config COMPRESS_SECONDARY_PAYLOAD</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "Use LZMA compression for secondary payloads"</span><br><span style="color: hsl(120, 100%, 40%);">+ default y</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ In order to reduce the size secondary payloads take up in the</span><br><span style="color: hsl(120, 100%, 40%);">+ ROM chip coreboot can compress them using the LZMA algorithm.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> menu "Secondary Payloads"</span><br><span> </span><br><span> config COREINFO_SECONDARY_PAYLOAD</span><br><span>diff --git a/payloads/Makefile.inc b/payloads/Makefile.inc</span><br><span>index b27d7fe..d894dec 100644</span><br><span>--- a/payloads/Makefile.inc</span><br><span>+++ b/payloads/Makefile.inc</span><br><span>@@ -16,10 +16,12 @@</span><br><span> cbfs-files-$(CONFIG_COREINFO_SECONDARY_PAYLOAD) += img/coreinfo</span><br><span> img/coreinfo-file := payloads/coreinfo/build/coreinfo.elf</span><br><span> img/coreinfo-type := payload</span><br><span style="color: hsl(120, 100%, 40%);">+img/coreinfo-compression := $(CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG)</span><br><span> </span><br><span> cbfs-files-$(CONFIG_NVRAMCUI_SECONDARY_PAYLOAD) += img/nvramcui</span><br><span> img/nvramcui-file := payloads/nvramcui/nvramcui.elf</span><br><span> img/nvramcui-type := payload</span><br><span style="color: hsl(120, 100%, 40%);">+img/nvramcui-compression := $(CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG)</span><br><span> </span><br><span> PAYLOADS_LIST=\</span><br><span> payloads/coreinfo \</span><br><span>diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc</span><br><span>index 62d8a44..ec7d9a8 100644</span><br><span>--- a/payloads/external/Makefile.inc</span><br><span>+++ b/payloads/external/Makefile.inc</span><br><span>@@ -185,12 +185,14 @@</span><br><span> cbfs-files-$(CONFIG_TINT_SECONDARY_PAYLOAD) += img/tint</span><br><span> img/tint-file := payloads/external/tint/tint/tint.elf</span><br><span> img/tint-type := payload</span><br><span style="color: hsl(120, 100%, 40%);">+img/tint-compression := $(CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG)</span><br><span> </span><br><span> # Memtest86+</span><br><span> </span><br><span> cbfs-files-$(CONFIG_MEMTEST_SECONDARY_PAYLOAD) += img/memtest</span><br><span> img/memtest-file := payloads/external/Memtest86Plus/memtest86plus/memtest</span><br><span> img/memtest-type := payload</span><br><span style="color: hsl(120, 100%, 40%);">+img/memtest-compression := $(CBFS_SECONDARY_PAYLOAD_COMPRESS_FLAG)</span><br><span> </span><br><span> ifeq ($(CONFIG_CONSOLE_SERIAL)$(CONFIG_DRIVERS_UART_8250IO),yy)</span><br><span> MEMTEST_SERIAL_OPTIONS=SERIAL_CONSOLE_DEFAULT=1 \</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23639">change 23639</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23639"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iddfd6fcf4112d255cc7b2b49b99bf5ea4d6f8db4 </div>
<div style="display:none"> Gerrit-Change-Number: 23639 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>