<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23594">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nami: Change WiFi wake pin to GPP_E22<br><br>This change updates the WiFi device wake pin to GPP_E22 from WAKE# (to<br>match the latest schematic changes).<br><br>BUG=b:72697650<br>TEST=Verified:<br>1. Wake-on-wifi works.<br>2. Device is able to enter G3 without WAKE# pin causing unwanted wakes<br>from deep S5.<br><br>Change-Id: Ibde81f73cca322f9b8b45baf8ee18ae00521467d<br>Signed-off-by: Furquan Shaikh <furquan@chromium.org><br>---<br>M src/mainboard/google/poppy/variants/nami/devicetree.cb<br>M src/mainboard/google/poppy/variants/nami/gpio.c<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/23594/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>index 348f7de..0149f28 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb</span><br><span>@@ -5,7 +5,7 @@</span><br><span>        register "deep_s3_enable_dc" = "1"</span><br><span>       register "deep_s5_enable_ac" = "1"</span><br><span>       register "deep_s5_enable_dc" = "1"</span><br><span style="color: hsl(0, 100%, 40%);">-  register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD"</span><br><span style="color: hsl(120, 100%, 40%);">+       register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD"</span><br><span> </span><br><span>    # GPE configuration</span><br><span>  # Note that GPE events called out in ASL code rely on this</span><br><span>@@ -291,7 +291,7 @@</span><br><span>             device pci 1c.2 off end # PCI Express Port 3</span><br><span>                 device pci 1c.3 on</span><br><span>                   chip drivers/intel/wifi</span><br><span style="color: hsl(0, 100%, 40%);">-                         register "wake" = "GPE0_PCI_EXP"</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "wake" = "GPE0_DW2_22"</span><br><span>                          device pci 00.0 on end</span><br><span>                       end</span><br><span>          end # PCI Express Port 4</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>index dbee643..e85d948 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/nami/gpio.c</span><br><span>@@ -253,8 +253,8 @@</span><br><span>      PAD_CFG_NF(GPP_E20, NONE, DEEP, NF1),</span><br><span>        /* E21 : DDPC_CTRLDATA ==> SOC_DP2_CTRL_DATA */</span><br><span>   PAD_CFG_NF(GPP_E21, NONE, DEEP, NF1),</span><br><span style="color: hsl(0, 100%, 40%);">-   /* E22 : DDPD_CTRLCLK ==> NC */</span><br><span style="color: hsl(0, 100%, 40%);">-      PAD_CFG_NC(GPP_E22),</span><br><span style="color: hsl(120, 100%, 40%);">+  /* E22 : DDPD_CTRLCLK ==> WLAN_PCIE_WAKE# */</span><br><span style="color: hsl(120, 100%, 40%);">+       PAD_CFG_GPI_ACPI_SCI(GPP_E22, NONE, DEEP, INVERT),</span><br><span>   /* E23 : DDPD_CTRLDATA ==> NC */</span><br><span>  PAD_CFG_NC(GPP_E23),</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23594">change 23594</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23594"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibde81f73cca322f9b8b45baf8ee18ae00521467d </div>
<div style="display:none"> Gerrit-Change-Number: 23594 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>