<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23563">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ec/google/chromeec: Remove wake flag from keyboard IRQ<br><br>The keyboard IRQ was changed to ExclusiveAndWake in order to support<br>waking from suspend-to-idle (S0ix) with commit<br>f611fcfacac5be14a51e04ae4d0b1e25cd5439c0 (http://review.coreboot.org/11712)<br><br>However this is triggering a kernel panic on Windows 10 because it<br>apparently does not like legacy devices interrupts to to be set as<br>wake capable.<br><br>This change is no longer necessary because the linux kernel was<br>changed to always treat the keyboard as wake capable:<br>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/input/serio/i8042.c?id=f13b2065de8147a1652b830ea5db961cf80c09df<br><br>Change-Id: I26e27de68095f8d176108f39312338522d7cfba0<br>Signed-off-by: Duncan Laurie <dlaurie@chromium.org><br>---<br>M src/ec/google/chromeec/acpi/superio.asl<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/23563/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl</span><br><span>index 0f06e30..7cd6523 100644</span><br><span>--- a/src/ec/google/chromeec/acpi/superio.asl</span><br><span>+++ b/src/ec/google/chromeec/acpi/superio.asl</span><br><span>@@ -151,7 +151,7 @@</span><br><span> #ifdef SIO_EC_PS2K_IRQ</span><br><span>                         SIO_EC_PS2K_IRQ</span><br><span> #else</span><br><span style="color: hsl(0, 100%, 40%);">-                        IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1}</span><br><span style="color: hsl(120, 100%, 40%);">+                  IRQ (Edge, ActiveHigh, Exclusive) {1}</span><br><span> #endif</span><br><span>              })</span><br><span> </span><br><span>@@ -163,7 +163,7 @@</span><br><span> #ifdef SIO_EC_PS2K_IRQ</span><br><span>                               SIO_EC_PS2K_IRQ</span><br><span> #else</span><br><span style="color: hsl(0, 100%, 40%);">-                                IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1}</span><br><span style="color: hsl(120, 100%, 40%);">+                          IRQ (Edge, ActiveHigh, Exclusive) {1}</span><br><span> #endif</span><br><span>                      }</span><br><span>                    EndDependentFn ()</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23563">change 23563</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23563"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I26e27de68095f8d176108f39312338522d7cfba0 </div>
<div style="display:none"> Gerrit-Change-Number: 23563 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>