<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23573">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/stoneyridge/acpi/sb_pci0_fch.asl: Fix instability<br><br>A file that has several methods cannot be included inside a method. It has<br>to be included inside a scope, but not inside a method or it'll cause<br>problems (instability).<br><br>BUG=b:62200858<br>TEST=Build kahlee.<br><br>Change-Id: If6c877df5a87df1b348de92868b91eed4a76de55<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl<br>1 file changed, 10 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/23573/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl</span><br><span>index 216b57c..ad7326c 100644</span><br><span>--- a/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl</span><br><span>+++ b/src/soc/amd/stoneyridge/acpi/sb_pci0_fch.asl</span><br><span>@@ -130,6 +130,10 @@</span><br><span>       Return(CRES) /* note to change the Name buffer */</span><br><span> } /* end of Method(_SB.PCI0._CRS) */</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#if IS_ENABLED(CONFIG_STONEYRIDGE_IMC_FWM)</span><br><span style="color: hsl(120, 100%, 40%);">+     #include "acpi/AmdImc.asl"</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /*</span><br><span>  *</span><br><span>  *               FIRST METHOD CALLED UPON BOOT</span><br><span>@@ -155,9 +159,13 @@</span><br><span>  /* Determine the OS we're running on */</span><br><span>  OSFL()</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This is an ugly temporary construction part of a group of commits that</span><br><span style="color: hsl(120, 100%, 40%);">+ * will remove all #if from ASL files. This message plus this temporary</span><br><span style="color: hsl(120, 100%, 40%);">+ * construction will be removed in next commit from the series, its sole</span><br><span style="color: hsl(120, 100%, 40%);">+ * purpose to facilitate next commit.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> #if IS_ENABLED(CONFIG_STONEYRIDGE_IMC_FWM)</span><br><span style="color: hsl(0, 100%, 40%);">-  /* TODO: It is unstable. */</span><br><span style="color: hsl(0, 100%, 40%);">-     #include "acpi/AmdImc.asl"</span><br><span> #if IS_ENABLED(CONFIG_ACPI_ENABLE_THERMAL_ZONE)</span><br><span>      ITZE() /* enable IMC Fan Control*/</span><br><span> #endif</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23573">change 23573</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23573"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If6c877df5a87df1b348de92868b91eed4a76de55 </div>
<div style="display:none"> Gerrit-Change-Number: 23573 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>