<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23537">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/msi/ms9652_fam10: Fix coding style<br><br>Change-Id: I8d6f738d358a0a3d4b602a2a607143d98f4710ed<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/msi/ms9652_fam10/get_bus_conf.c<br>M src/mainboard/msi/ms9652_fam10/mptable.c<br>2 files changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/23537/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/msi/ms9652_fam10/get_bus_conf.c b/src/mainboard/msi/ms9652_fam10/get_bus_conf.c</span><br><span>index 0614e1f..19f8d3b 100644</span><br><span>--- a/src/mainboard/msi/ms9652_fam10/get_bus_conf.c</span><br><span>+++ b/src/mainboard/msi/ms9652_fam10/get_bus_conf.c</span><br><span>@@ -70,7 +70,8 @@</span><br><span> </span><br><span> printk(BIOS_SPEW, "get_bus_conf()\n");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if(get_bus_conf_done == 1) return; //do it only once</span><br><span style="color: hsl(120, 100%, 40%);">+ if (get_bus_conf_done == 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ return; //do it only once</span><br><span> </span><br><span> get_bus_conf_done = 1;</span><br><span> </span><br><span>@@ -80,7 +81,7 @@</span><br><span> memset(m, 0, sizeof(struct mb_sysconf_t));</span><br><span> </span><br><span> sysconf.hc_possible_num = ARRAY_SIZE(pci1234x);</span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 0; i < sysconf.hc_possible_num; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < sysconf.hc_possible_num; i++) {</span><br><span> sysconf.pci1234[i] = pci1234x[i];</span><br><span> sysconf.hcdn[i] = hcdnx[i];</span><br><span> }</span><br><span>@@ -99,7 +100,7 @@</span><br><span> printk(BIOS_DEBUG, "ERROR - could not find PCI 1:%02x.0, using defaults\n", sysconf.sbdn + 0x06);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 2; i < 8; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 2; i < 8; i++) {</span><br><span> dev = dev_find_slot(m->bus_mcp55[0], PCI_DEVFN(sysconf.sbdn + 0x0a + i - 2 , 0));</span><br><span> if (dev) {</span><br><span> m->bus_mcp55[i] = pci_read_config8(dev, PCI_SECONDARY_BUS);</span><br><span>diff --git a/src/mainboard/msi/ms9652_fam10/mptable.c b/src/mainboard/msi/ms9652_fam10/mptable.c</span><br><span>index 7d83c46..6adc53e 100644</span><br><span>--- a/src/mainboard/msi/ms9652_fam10/mptable.c</span><br><span>+++ b/src/mainboard/msi/ms9652_fam10/mptable.c</span><br><span>@@ -88,17 +88,16 @@</span><br><span> smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55[0], ((sbdn+8)<<2)|0, m->apicid_mcp55, 0x16); // 22</span><br><span> smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55[0], ((sbdn+9)<<2)|0, m->apicid_mcp55, 0x15); // 21</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- for(j = 7; j >= 2; j--) {</span><br><span style="color: hsl(0, 100%, 40%);">- if(!m->bus_mcp55[j]) continue;</span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 0; i < 4; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (j = 7; j >= 2; j--) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!m->bus_mcp55[j])</span><br><span style="color: hsl(120, 100%, 40%);">+ continue;</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 4; i++)</span><br><span> smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55[j], (0x00 << 2)|i, m->apicid_mcp55, 0x10 + (2+j+i+4-sbdn%4)%4);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- for(j = 0; j < 1; j++)</span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 0; i < 4; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (j = 0; j < 1; j++)</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 4; i++)</span><br><span> smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, m->bus_mcp55[1], ((0x04+j)<<2)|i, m->apicid_mcp55, 0x10 + (2+i+j)%4);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> </span><br><span> /*Local Ints: Type Polarity Trigger Bus ID IRQ APIC ID PIN#*/</span><br><span> mptable_lintsrc(mc, bus_isa);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23537">change 23537</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23537"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8d6f738d358a0a3d4b602a2a607143d98f4710ed </div>
<div style="display:none"> Gerrit-Change-Number: 23537 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>