<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23530">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/gigabyte/m57sli: Fix coding style<br><br>Change-Id: If469989a33b7aaca55503108601fb158f264fc06<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/gigabyte/m57sli/mptable.c<br>1 file changed, 20 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/23530/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/gigabyte/m57sli/mptable.c b/src/mainboard/gigabyte/m57sli/mptable.c</span><br><span>index 019a7f5..e0af483 100644</span><br><span>--- a/src/mainboard/gigabyte/m57sli/mptable.c</span><br><span>+++ b/src/mainboard/gigabyte/m57sli/mptable.c</span><br><span>@@ -49,7 +49,7 @@</span><br><span> device_t dev;</span><br><span> struct resource *res;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- dev = dev_find_slot(bus_mcp55[0], PCI_DEVFN(sbdn+ 0x1,0));</span><br><span style="color: hsl(120, 100%, 40%);">+ dev = dev_find_slot(bus_mcp55[0], PCI_DEVFN(sbdn + 0x1, 0));</span><br><span> if (dev) {</span><br><span> res = find_resource(dev, PCI_BASE_ADDRESS_1);</span><br><span> if (res) {</span><br><span>@@ -72,22 +72,23 @@</span><br><span> smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW,\</span><br><span> bus_mcp55[bus], (((dev)<<2)|(fn)), apicid_mcp55, (pin))</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(0,sbdn+1,1, 10); /* SMBus */</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(0,sbdn+2,0, 22); /* USB */</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(0,sbdn+2,1, 23); /* USB */</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(0,sbdn+4,0, 21); /* IDE */</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(0,sbdn+5,0, 20); /* SATA */</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(0,sbdn+5,1, 21); /* SATA */</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(0,sbdn+5,2, 22); /* SATA */</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(0,sbdn+6,1, 23); /* HD Audio */</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(0,sbdn+8,0, 20); /* GBit Ethernet */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(0, sbdn + 1, 1, 10); /* SMBus */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(0, sbdn + 2, 0, 22); /* USB */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(0, sbdn + 2, 1, 23); /* USB */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(0, sbdn + 4, 0, 21); /* IDE */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(0, sbdn + 5, 0, 20); /* SATA */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(0, sbdn + 5, 1, 21); /* SATA */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(0, sbdn + 5, 2, 22); /* SATA */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(0, sbdn + 6, 1, 23); /* HD Audio */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(0, sbdn + 8, 0, 20); /* GBit Ethernet */</span><br><span> </span><br><span> /* The PCIe slots, each on its own bus */</span><br><span> k = 1;</span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 0; i < 4; i++){</span><br><span style="color: hsl(0, 100%, 40%);">- for(j = 7; j > 1; j--){</span><br><span style="color: hsl(0, 100%, 40%);">- if(k > 3) k = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(j,0,i, 16+k);</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 4; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (j = 7; j > 1; j--) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (k > 3)</span><br><span style="color: hsl(120, 100%, 40%);">+ k = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(j, 0, i, 16 + k);</span><br><span> k++;</span><br><span> }</span><br><span> k--;</span><br><span>@@ -98,10 +99,11 @@</span><br><span> * FireWire is j = 10</span><br><span> */</span><br><span> k = 2;</span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 0; i < 4; i++){</span><br><span style="color: hsl(0, 100%, 40%);">- for(j = 6; j < 11; j++){</span><br><span style="color: hsl(0, 100%, 40%);">- if(k > 3) k = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- PCI_INT(1,j,i, 16+k);</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 4; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (j = 6; j < 11; j++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (k > 3)</span><br><span style="color: hsl(120, 100%, 40%);">+ k = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ PCI_INT(1, j, i, 16 + k);</span><br><span> k++;</span><br><span> }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23530">change 23530</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23530"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If469989a33b7aaca55503108601fb158f264fc06 </div>
<div style="display:none"> Gerrit-Change-Number: 23530 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>