<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23532">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/hp/dl145_g3: Fix coding style<br><br>Change-Id: I78b43cbc052e6d243d67ca8cdd86b242e477a2c7<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/hp/dl145_g3/get_bus_conf.c<br>M src/mainboard/hp/dl145_g3/mptable.c<br>2 files changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/23532/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/hp/dl145_g3/get_bus_conf.c b/src/mainboard/hp/dl145_g3/get_bus_conf.c</span><br><span>index d69e224..9cbb7ba 100644</span><br><span>--- a/src/mainboard/hp/dl145_g3/get_bus_conf.c</span><br><span>+++ b/src/mainboard/hp/dl145_g3/get_bus_conf.c</span><br><span>@@ -68,7 +68,8 @@</span><br><span>         int i;</span><br><span>       struct mb_sysconf_t *m;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     if(get_bus_conf_done == 1) return; //do it only once</span><br><span style="color: hsl(120, 100%, 40%);">+  if (get_bus_conf_done == 1)</span><br><span style="color: hsl(120, 100%, 40%);">+           return; //do it only once</span><br><span> </span><br><span>        get_bus_conf_done = 1;</span><br><span> </span><br><span>@@ -78,7 +79,7 @@</span><br><span> </span><br><span>   sysconf.hc_possible_num = ARRAY_SIZE(pci1234x);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     for(i = 0; i < sysconf.hc_possible_num; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+     for (i = 0; i < sysconf.hc_possible_num; i++) {</span><br><span>           sysconf.pci1234[i] = pci1234x[i];</span><br><span>            sysconf.hcdn[i] = hcdnx[i];</span><br><span>  }</span><br><span>@@ -100,18 +101,17 @@</span><br><span>            printk(BIOS_DEBUG, "secondary is %d...\n",m->bus_bcm5785_1);</span><br><span>            dev = dev_find_slot(m->bus_bcm5785_1, PCI_DEVFN(0xd,0));</span><br><span>          printk(BIOS_DEBUG, "now found %s...\n",dev_path(dev));</span><br><span style="color: hsl(0, 100%, 40%);">-                if(dev) {</span><br><span style="color: hsl(120, 100%, 40%);">+             if (dev)</span><br><span>                     m->bus_bcm5785_1_1 = pci_read_config8(dev, PCI_SECONDARY_BUS);</span><br><span style="color: hsl(0, 100%, 40%);">-               }</span><br><span>    }</span><br><span>    else {</span><br><span>               printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_bcm5785_0, sysconf.sbdn);</span><br><span>         }</span><br><span> </span><br><span>                /* bcm5780 */</span><br><span style="color: hsl(0, 100%, 40%);">-   for(i = 1; i < 6; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+   for (i = 1; i < 6; i++) {</span><br><span>                 dev = dev_find_slot(m->bus_bcm5780[0], PCI_DEVFN(m->sbdn2 + i - 1,0));</span><br><span style="color: hsl(0, 100%, 40%);">-            if(dev) {</span><br><span style="color: hsl(120, 100%, 40%);">+             if (dev) {</span><br><span>                   m->bus_bcm5780[i] = pci_read_config8(dev, PCI_SECONDARY_BUS);</span><br><span>             }</span><br><span>            else {</span><br><span>diff --git a/src/mainboard/hp/dl145_g3/mptable.c b/src/mainboard/hp/dl145_g3/mptable.c</span><br><span>index 86affe8..4e33f9b 100644</span><br><span>--- a/src/mainboard/hp/dl145_g3/mptable.c</span><br><span>+++ b/src/mainboard/hp/dl145_g3/mptable.c</span><br><span>@@ -57,7 +57,7 @@</span><br><span>          device_t dev = 0;</span><br><span>            int i;</span><br><span>               struct resource *res;</span><br><span style="color: hsl(0, 100%, 40%);">-           for(i = 0; i < 3; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+           for (i = 0; i < 3; i++) {</span><br><span>                         dev = dev_find_device(0x1166, 0x0235, dev);</span><br><span>                  if (dev) {</span><br><span>                           res = find_resource(dev, PCI_BASE_ADDRESS_0);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23532">change 23532</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23532"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I78b43cbc052e6d243d67ca8cdd86b242e477a2c7 </div>
<div style="display:none"> Gerrit-Change-Number: 23532 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>