<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23531">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/hp/dl145_g1: Fix coding style<br><br>Change-Id: I8cfddbf49b3042d46956985425990360f0903b1f<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/hp/dl145_g1/acpi_tables.c<br>M src/mainboard/hp/dl145_g1/get_bus_conf.c<br>M src/mainboard/hp/dl145_g1/romstage.c<br>3 files changed, 14 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/23531/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/hp/dl145_g1/acpi_tables.c b/src/mainboard/hp/dl145_g1/acpi_tables.c</span><br><span>index 1b4ada1..1084bfb 100644</span><br><span>--- a/src/mainboard/hp/dl145_g1/acpi_tables.c</span><br><span>+++ b/src/mainboard/hp/dl145_g1/acpi_tables.c</span><br><span>@@ -66,9 +66,10 @@</span><br><span>              int i;</span><br><span>               int j = 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-          for(i = 1; i< sysconf.hc_possible_num; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+              for (i = 1; i < sysconf.hc_possible_num; i++) {</span><br><span>                   unsigned d = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-                 if(!(sysconf.pci1234[i] & 0x1) ) continue;</span><br><span style="color: hsl(120, 100%, 40%);">+                        if (!(sysconf.pci1234[i] & 0x1))</span><br><span style="color: hsl(120, 100%, 40%);">+                          continue;</span><br><span>                    // 8131 need to use +4</span><br><span> </span><br><span>                   switch (sysconf.hcid[i]) {</span><br><span>diff --git a/src/mainboard/hp/dl145_g1/get_bus_conf.c b/src/mainboard/hp/dl145_g1/get_bus_conf.c</span><br><span>index da02095..7a9e3b5 100644</span><br><span>--- a/src/mainboard/hp/dl145_g1/get_bus_conf.c</span><br><span>+++ b/src/mainboard/hp/dl145_g1/get_bus_conf.c</span><br><span>@@ -52,7 +52,8 @@</span><br><span>  device_t dev;</span><br><span>        int i;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      if(get_bus_conf_done == 1) return; //do it only once</span><br><span style="color: hsl(120, 100%, 40%);">+  if (get_bus_conf_done == 1)</span><br><span style="color: hsl(120, 100%, 40%);">+           return; //do it only once</span><br><span> </span><br><span>        get_bus_conf_done = 1;</span><br><span> </span><br><span>@@ -60,7 +61,7 @@</span><br><span>       struct mb_sysconf_t *m = sysconf.mb;</span><br><span> </span><br><span>     sysconf.hc_possible_num = ARRAY_SIZE(pci1234x);</span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 0; i < sysconf.hc_possible_num; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+     for (i = 0; i < sysconf.hc_possible_num; i++) {</span><br><span>           sysconf.pci1234[i] = pci1234x[i];</span><br><span>            sysconf.hcdn[i] = hcdnx[i];</span><br><span>  }</span><br><span>@@ -75,30 +76,24 @@</span><br><span> </span><br><span>  /* 8111 */</span><br><span>   dev = dev_find_slot(m->bus_8111_0, PCI_DEVFN(sysconf.sbdn,0));</span><br><span style="color: hsl(0, 100%, 40%);">-       if (dev) {</span><br><span style="color: hsl(120, 100%, 40%);">+    if (dev)</span><br><span>             m->bus_8111_1 = pci_read_config8(dev, PCI_SECONDARY_BUS);</span><br><span style="color: hsl(0, 100%, 40%);">-    }</span><br><span style="color: hsl(0, 100%, 40%);">-       else {</span><br><span style="color: hsl(120, 100%, 40%);">+        else</span><br><span>                 printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:03.0, using defaults\n", m->bus_8111_0);</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span> </span><br><span>        /* 8131-1 */</span><br><span>         dev = dev_find_slot(m->bus_8131_0, PCI_DEVFN(m->sbdn3,0));</span><br><span style="color: hsl(0, 100%, 40%);">-        if (dev) {</span><br><span style="color: hsl(120, 100%, 40%);">+    if (dev)</span><br><span>             m->bus_8131_1 = pci_read_config8(dev, PCI_SECONDARY_BUS);</span><br><span style="color: hsl(0, 100%, 40%);">-    }</span><br><span style="color: hsl(0, 100%, 40%);">-       else {</span><br><span style="color: hsl(120, 100%, 40%);">+        else</span><br><span>                 printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:01.0, using defaults\n", m->bus_8131_0);</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span> </span><br><span>        /* 8131-2 */</span><br><span>         dev = dev_find_slot(m->bus_8131_0, PCI_DEVFN(m->sbdn3+1,0));</span><br><span style="color: hsl(0, 100%, 40%);">-      if (dev) {</span><br><span style="color: hsl(120, 100%, 40%);">+    if (dev)</span><br><span>             m->bus_8131_2 = pci_read_config8(dev, PCI_SECONDARY_BUS);</span><br><span style="color: hsl(0, 100%, 40%);">-    }</span><br><span style="color: hsl(0, 100%, 40%);">-       else {</span><br><span style="color: hsl(120, 100%, 40%);">+        else</span><br><span>                 printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:02.0, using defaults\n", m->bus_8131_0);</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span> </span><br><span> </span><br><span> /*I/O APICs:       APIC ID Version State           Address*/</span><br><span>diff --git a/src/mainboard/hp/dl145_g1/romstage.c b/src/mainboard/hp/dl145_g1/romstage.c</span><br><span>index 91f03a7..1ef3658 100644</span><br><span>--- a/src/mainboard/hp/dl145_g1/romstage.c</span><br><span>+++ b/src/mainboard/hp/dl145_g1/romstage.c</span><br><span>@@ -175,12 +175,10 @@</span><br><span>       enable_smbus();</span><br><span> </span><br><span>  int i;</span><br><span style="color: hsl(0, 100%, 40%);">-  for(i = 0; i < 2; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+   for (i = 0; i < 2; i++)</span><br><span>           activate_spd_rom(&sysinfo->ctrl[i]);</span><br><span style="color: hsl(0, 100%, 40%);">-     }</span><br><span style="color: hsl(0, 100%, 40%);">-       for(i = RC0; i <= RC1; i<<=1) {</span><br><span style="color: hsl(120, 100%, 40%);">+      for (i = RC0; i <= RC1; i <<= 1)</span><br><span>            change_i2c_mux(i);</span><br><span style="color: hsl(0, 100%, 40%);">-      }</span><br><span> </span><br><span>        //dump_spd_registers(&sysinfo->ctrl[0]);</span><br><span>      //dump_spd_registers(&sysinfo->ctrl[1]);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23531">change 23531</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23531"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8cfddbf49b3042d46956985425990360f0903b1f </div>
<div style="display:none"> Gerrit-Change-Number: 23531 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>