<p>Elyes HAOUAS has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23533">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/hp/dl165_g6_fam10: Fix coding style<br><br>Change-Id: I3e3bb9a0e9670fca67016523eac437140ff03188<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>---<br>M src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c<br>M src/mainboard/hp/dl165_g6_fam10/mptable.c<br>2 files changed, 11 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/23533/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c b/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c</span><br><span>index 68c3881..84c7c9b 100644</span><br><span>--- a/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c</span><br><span>+++ b/src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c</span><br><span>@@ -69,7 +69,8 @@</span><br><span> int i;</span><br><span> struct mb_sysconf_t *m;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if(get_bus_conf_done == 1) return; //do it only once</span><br><span style="color: hsl(120, 100%, 40%);">+ if (get_bus_conf_done == 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ return; //do it only once</span><br><span> </span><br><span> get_bus_conf_done = 1;</span><br><span> </span><br><span>@@ -80,7 +81,7 @@</span><br><span> </span><br><span> sysconf.hc_possible_num = ARRAY_SIZE(pci1234x);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 0; i < sysconf.hc_possible_num; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < sysconf.hc_possible_num; i++) {</span><br><span> sysconf.pci1234[i] = pci1234x[i];</span><br><span> sysconf.hcdn[i] = hcdnx[i];</span><br><span> }</span><br><span>@@ -102,28 +103,24 @@</span><br><span> printk(BIOS_DEBUG, "secondary is %d...\n",m->bus_bcm5785_1);</span><br><span> dev = dev_find_slot(m->bus_bcm5785_1, PCI_DEVFN(0xd,0));</span><br><span> printk(BIOS_DEBUG, "now found %s...\n",dev_path(dev));</span><br><span style="color: hsl(0, 100%, 40%);">- if(dev) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dev)</span><br><span> m->bus_bcm5785_1_1 = pci_read_config8(dev, PCI_SECONDARY_BUS);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> }</span><br><span> else {</span><br><span> printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_bcm5785_0, sysconf.sbdn);</span><br><span> }</span><br><span> </span><br><span> /* bcm5780 */</span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 1; i < 6; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 1; i < 6; i++) {</span><br><span> dev = dev_find_slot(m->bus_bcm5780[0], PCI_DEVFN(m->sbdn2 + i - 1,0));</span><br><span style="color: hsl(0, 100%, 40%);">- if(dev) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dev)</span><br><span> m->bus_bcm5780[i] = pci_read_config8(dev, PCI_SECONDARY_BUS);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- else {</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span> printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_bcm5780[0], m->sbdn2+i-1);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> }</span><br><span> </span><br><span> /*I/O APICs: APIC ID Version State Address*/</span><br><span> apicid_base = 0x10;</span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 0; i < 3; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 3; i++)</span><br><span> m->apicid_bcm5785[i] = apicid_base+i;</span><br><span> }</span><br><span>diff --git a/src/mainboard/hp/dl165_g6_fam10/mptable.c b/src/mainboard/hp/dl165_g6_fam10/mptable.c</span><br><span>index b1c91c8..6a27d97 100644</span><br><span>--- a/src/mainboard/hp/dl165_g6_fam10/mptable.c</span><br><span>+++ b/src/mainboard/hp/dl165_g6_fam10/mptable.c</span><br><span>@@ -58,7 +58,7 @@</span><br><span> device_t dev = 0;</span><br><span> int i;</span><br><span> struct resource *res;</span><br><span style="color: hsl(0, 100%, 40%);">- for(i = 0; i < 3; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 3; i++) {</span><br><span> dev = dev_find_device(0x1166, 0x0235, dev);</span><br><span> if (dev) {</span><br><span> res = find_resource(dev, PCI_BASE_ADDRESS_0);</span><br><span>@@ -86,7 +86,7 @@</span><br><span> {</span><br><span> device_t dev;</span><br><span> dev = dev_find_device(0x1166, 0x0205, 0);</span><br><span style="color: hsl(0, 100%, 40%);">- if(dev) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dev) {</span><br><span> uint32_t dword;</span><br><span> dword = pci_read_config32(dev, 0x64);</span><br><span> dword |= (1 << 30); // GEVENT14-21 used as PCI IRQ0-7</span><br><span>@@ -129,7 +129,7 @@</span><br><span> {</span><br><span> device_t dev;</span><br><span> dev = dev_find_device(0x1166, 0x0205, 0);</span><br><span style="color: hsl(0, 100%, 40%);">- if(dev) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dev) {</span><br><span> uint32_t dword;</span><br><span> dword = pci_read_config32(dev, 0x6c);</span><br><span> dword |= (1 << 4); // enable interrupts</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23533">change 23533</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23533"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3e3bb9a0e9670fca67016523eac437140ff03188 </div>
<div style="display:none"> Gerrit-Change-Number: 23533 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>