<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23550">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/pineview: Avoid holes between TOM and cbmem_top<br><br>Having usable memory between top of lower usable memory and cbmem_top<br>creates problems for some payloads like tianocore and some versions of<br>memtest86+ don't like it either.<br><br>The solution is to mark that memory as reserved.<br><br>Change-Id: If5146cda1020b494af6d43e5d8055e0045fa5b82<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/northbridge/intel/pineview/northbridge.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/23550/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/northbridge/intel/pineview/northbridge.c b/src/northbridge/intel/pineview/northbridge.c</span><br><span>index ea55974..ca6a1c2 100644</span><br><span>--- a/src/northbridge/intel/pineview/northbridge.c</span><br><span>+++ b/src/northbridge/intel/pineview/northbridge.c</span><br><span>@@ -98,6 +98,8 @@</span><br><span>         /* Subtract TSEG size */</span><br><span>     tseg_sizek = gtt_basek - tseg_basek;</span><br><span>         tomk -= tseg_sizek;</span><br><span style="color: hsl(120, 100%, 40%);">+   /* Align top of ram down to cbmem_top */</span><br><span style="color: hsl(120, 100%, 40%);">+      tomk = ALIGN_DOWN(tomk, 4 << 10);</span><br><span> </span><br><span>  /* Report the memory regions */</span><br><span>      ram_resource(dev, index++, 0, 640);</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23550">change 23550</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23550"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If5146cda1020b494af6d43e5d8055e0045fa5b82 </div>
<div style="display:none"> Gerrit-Change-Number: 23550 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>