<p>Justin TerAvest has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23508">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/kahlee: Add grunt trackpad in devicetree<br><br>This commit removes a manually written asl file in favor of configuring<br>the trackpad through devicetree.<br><br>BUG=b:72121803<br>TEST=cat /proc/interrupts with trackpad connected<br><br>Change-Id: I38afcf89ea64ffaf6a10bb317c41154feda57e50<br>Signed-off-by: Justin TerAvest <teravest@chromium.org><br>---<br>M src/mainboard/google/kahlee/variants/grunt/devicetree.cb<br>M src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/mainboard.asl<br>2 files changed, 9 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/23508/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb</span><br><span>index d2453a1..22c3653 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb</span><br><span>+++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb</span><br><span>@@ -81,6 +81,15 @@</span><br><span>              device pci 18.4 on  end</span><br><span>              device pci 18.5 on  end</span><br><span>      end #domain</span><br><span style="color: hsl(120, 100%, 40%);">+   device mmio 0xfedc4000 on</span><br><span style="color: hsl(120, 100%, 40%);">+             chip drivers/i2c/generic</span><br><span style="color: hsl(120, 100%, 40%);">+                      register "hid" = ""ELAN0000""</span><br><span style="color: hsl(120, 100%, 40%);">+                   register "desc" = ""ELAN Touchpad""</span><br><span style="color: hsl(120, 100%, 40%);">+                     register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)"</span><br><span style="color: hsl(120, 100%, 40%);">+                   # TODO(teravest): Add wake</span><br><span style="color: hsl(120, 100%, 40%);">+                    device i2c 15 on end</span><br><span style="color: hsl(120, 100%, 40%);">+          end</span><br><span style="color: hsl(120, 100%, 40%);">+   end</span><br><span>  device mmio 0xfedc5000 on</span><br><span>            chip drivers/i2c/generic</span><br><span>                     register "hid" = ""ELAN0001""</span><br><span>diff --git a/src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/mainboard.asl b/src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/mainboard.asl</span><br><span>index 900a838..4f91d72 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/mainboard.asl</span><br><span>+++ b/src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/mainboard.asl</span><br><span>@@ -15,4 +15,3 @@</span><br><span> </span><br><span> #include <baseboard/acpi/mainboard.asl></span><br><span> #include <baseboard/acpi/audio.asl></span><br><span style="color: hsl(0, 100%, 40%);">-#include <baseboard/acpi/touchpad.asl></span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23508">change 23508</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23508"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I38afcf89ea64ffaf6a10bb317c41154feda57e50 </div>
<div style="display:none"> Gerrit-Change-Number: 23508 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Justin TerAvest <teravest@chromium.org> </div>