<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23373">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">payloads/nvramcui/payload.sh<br><br>Fix shellcheck warnings:<br><br>In payloads/nvramcui/payload.sh line 5:<br>DIR=`dirname $0`<br>    ^-- SC2006: Use $(..) instead of deprecated `..`<br>             ^-- SC2086: Double quote to prevent globbing and word \<br>                 splitting.<br><br>In payloads/nvramcui/payload.sh line 6:<br>lpgcc -o $DIR/nvramcui.elf $DIR/nvramcui.c 2>&1 >/dev/null || exit 1<br>         ^-- SC2086: Double quote to prevent globbing and word \<br>             splitting.<br>                           ^-- SC2086: Double quote to prevent \<br>                               globbing and word splitting.<br>                                           ^-- SC2069: The order of \<br>                                                of the 2>&1 and the \<br>                                                redirect matters. The \<br>                                                2>&1 has to be last.<br><br>Change-Id: Iceab2d0df49c642f54e6b911793aa1479f542644<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M payloads/nvramcui/payload.sh<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/23373/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/payloads/nvramcui/payload.sh b/payloads/nvramcui/payload.sh</span><br><span>index 57ed38b..3d171e6 100755</span><br><span>--- a/payloads/nvramcui/payload.sh</span><br><span>+++ b/payloads/nvramcui/payload.sh</span><br><span>@@ -2,6 +2,6 @@</span><br><span> #</span><br><span> # This is a trivial payload compile & find script for abuild</span><br><span> #</span><br><span style="color: hsl(0, 100%, 40%);">-DIR=`dirname $0`</span><br><span style="color: hsl(0, 100%, 40%);">-lpgcc -o $DIR/nvramcui.elf $DIR/nvramcui.c 2>&1 >/dev/null || exit 1</span><br><span style="color: hsl(120, 100%, 40%);">+DIR=$(dirname "$0")</span><br><span style="color: hsl(120, 100%, 40%);">+lpgcc -o "$DIR/nvramcui.elf" "$DIR/nvramcui.c" >/dev/null 2>&1 || exit 1</span><br><span> echo "$DIR/nvramcui.elf"</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23373">change 23373</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23373"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iceab2d0df49c642f54e6b911793aa1479f542644 </div>
<div style="display:none"> Gerrit-Change-Number: 23373 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>