<p>Julien Viard de Galbert has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23396">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">smbios: handle DIMM of 32G or more<br><br>According to SMBIOS Reference Specification (1)<br>section 7.18.4 Memory Device — Extended Size<br><br>When the size cannot be represented in the size field, it must be set to<br>0x7fff and the real size stored in the extended_size field.<br><br>1: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_2.7.1.pdf<br><br>Change-Id: Idc559454c16ccd685aaaed0d60f1af69b634ea2e<br>Signed-off-by: Julien Viard de Galbert <jviarddegalbert@online.net><br>---<br>M src/arch/x86/smbios.c<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/23396/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c</span><br><span>index 89951a1..b6bafa7 100644</span><br><span>--- a/src/arch/x86/smbios.c</span><br><span>+++ b/src/arch/x86/smbios.c</span><br><span>@@ -207,7 +207,12 @@</span><br><span>         t->clock_speed = dimm->ddr_frequency;</span><br><span>  t->speed = dimm->ddr_frequency;</span><br><span>        t->type = SMBIOS_MEMORY_DEVICE;</span><br><span style="color: hsl(0, 100%, 40%);">-      t->size = dimm->dimm_size;</span><br><span style="color: hsl(120, 100%, 40%);">+      if (dimm->dimm_size < 0x7fff) {</span><br><span style="color: hsl(120, 100%, 40%);">+         t->size = dimm->dimm_size;</span><br><span style="color: hsl(120, 100%, 40%);">+      } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              t->size = 0x7fff;</span><br><span style="color: hsl(120, 100%, 40%);">+          t->extended_size = dimm->dimm_size;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span>    t->data_width = 8 * (1 << (dimm->bus_width & 0x7));</span><br><span>  t->total_width = t->data_width + 8 * ((dimm->bus_width & 0x18) >> 3);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23396">change 23396</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23396"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Idc559454c16ccd685aaaed0d60f1af69b634ea2e </div>
<div style="display:none"> Gerrit-Change-Number: 23396 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert@online.net> </div>