<p>Richard Spiegel has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23295">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">AMD/stoneyridge: Fix SATA reset inconsistency<br><br>At AGESA AmdInitReset, SATA enable and IDE enable (elements of<br>FCH_RESET_INTERFACE) are programmed twice (before calling AGESA<br>for AmdInitReset and from said AGESA function call out), using<br>different functions with different results. The first would result<br>in TRUE/FALSE, the second set would result in TRUE/TRUE. Use the<br>functions of the second set within the first set, and remove them<br>from the second set.<br><br>BUG=b:71754828<br>TEST=Build kahlle without the change, boot and record output. Rebuild<br>kahlee with the change, boot and record output. Compare both outputs,<br>the should be no change except in timing.<br><br>Change-Id: I326fcc8801542aa7feef286d02abdfe63354cdd0<br>Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com><br>---<br>M src/soc/amd/stoneyridge/BiosCallOuts.c<br>M src/soc/amd/stoneyridge/southbridge.c<br>2 files changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/23295/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/BiosCallOuts.c b/src/soc/amd/stoneyridge/BiosCallOuts.c</span><br><span>index f6ac187..cb225ec 100644</span><br><span>--- a/src/soc/amd/stoneyridge/BiosCallOuts.c</span><br><span>+++ b/src/soc/amd/stoneyridge/BiosCallOuts.c</span><br><span>@@ -35,8 +35,6 @@</span><br><span>              FCH_RESET_DATA_BLOCK *FchParams_reset;</span><br><span>               FchParams_reset = (FCH_RESET_DATA_BLOCK *)FchData;</span><br><span>           printk(BIOS_DEBUG, "Fch OEM config in INIT RESET ");</span><br><span style="color: hsl(0, 100%, 40%);">-          FchParams_reset->FchReset.SataEnable = sb_sata_enable();</span><br><span style="color: hsl(0, 100%, 40%);">-             FchParams_reset->FchReset.IdeEnable = sb_ide_enable();</span><br><span> </span><br><span>                /* Get platform specific configuration changes */</span><br><span>            platform_FchParams_reset(FchParams_reset);</span><br><span>diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c</span><br><span>index 1357257..0f92001 100644</span><br><span>--- a/src/soc/amd/stoneyridge/southbridge.c</span><br><span>+++ b/src/soc/amd/stoneyridge/southbridge.c</span><br><span>@@ -42,8 +42,8 @@</span><br><span> void SetFchResetParams(FCH_RESET_INTERFACE *params)</span><br><span> {</span><br><span>  params->Xhci0Enable = IS_ENABLED(CONFIG_STONEYRIDGE_XHCI_ENABLE);</span><br><span style="color: hsl(0, 100%, 40%);">-    params->SataEnable = is_sata_config();</span><br><span style="color: hsl(0, 100%, 40%);">-       params->IdeEnable = !params->SataEnable;</span><br><span style="color: hsl(120, 100%, 40%);">+        params->SataEnable = sb_sata_enable();</span><br><span style="color: hsl(120, 100%, 40%);">+     params->IdeEnable = sb_ide_enable();</span><br><span> }</span><br><span> </span><br><span> void SetFchEnvParams(FCH_INTERFACE *params)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23295">change 23295</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23295"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I326fcc8801542aa7feef286d02abdfe63354cdd0 </div>
<div style="display:none"> Gerrit-Change-Number: 23295 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>