<p>Hannah Williams has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23230">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: Fix ACPI BAR in PMC config space<br><br>read_resources in common/block/pmc/pmc.c is corrupting the BAR<br>at offset 0x20.<br><br>pch_pmc_read_resources<br>                      |<br>                      pci_dev_read_resources<br>                                            |<br>                                            pci_get_resource<br>Within pci_get_resource, the BAR is read and written back. Since<br>read of ACPI BAR does not return the correct value, the subsequent<br>write corrupts the BAR.<br>Hence re-programming the BAR<br><br>Change-Id: I27062419d06127951ecbbb641835d06ca39ff435<br>Signed-off-by: Hannah Williams <hannah.williams@intel.com><br>---<br>M src/soc/intel/apollolake/pmc.c<br>1 file changed, 4 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/23230/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/apollolake/pmc.c b/src/soc/intel/apollolake/pmc.c</span><br><span>index 58cb71a..e9e49af 100644</span><br><span>--- a/src/soc/intel/apollolake/pmc.c</span><br><span>+++ b/src/soc/intel/apollolake/pmc.c</span><br><span>@@ -95,6 +95,10 @@</span><br><span> {</span><br><span>        const struct soc_intel_apollolake_config *cfg = dev->chip_info;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        /* Restoring the BAR */</span><br><span style="color: hsl(120, 100%, 40%);">+       pci_write_config16(dev, PCI_BASE_ADDRESS_4, ACPI_BASE_ADDRESS);</span><br><span style="color: hsl(120, 100%, 40%);">+       pci_write_config16(dev, PCI_COMMAND,</span><br><span style="color: hsl(120, 100%, 40%);">+          PCI_COMMAND_IO | PCI_COMMAND_MASTER);</span><br><span>        /* Set up GPE configuration */</span><br><span>       pmc_gpe_init();</span><br><span>      pmc_fixup_power_state();</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23230">change 23230</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23230"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I27062419d06127951ecbbb641835d06ca39ff435 </div>
<div style="display:none"> Gerrit-Change-Number: 23230 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Hannah Williams <hannah.williams@intel.com> </div>