<p>Nick Vaccaro would like Nick Vaccaro to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/23195">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/zoombini/variants/meowth: fix gpio settings<br><br>-change GPP_C12 (H1 IRQ) to use GPI_SCI_LOW and level triggered<br>-set gspi gpios to no connects if CONFIG_ZOOMBINI_USE_SPI_TPM not set<br><br>BUG=b:69011806<br>BRANCH=chromeos-2016.05<br>TEST='emerge-meowth coreboot' succeeds<br><br>Change-Id: Ida1d1050db12982c3c497656162cc84c62a77f70<br>Signed-off-by: Nick Vaccaro <nvaccaro@chromium.org><br>---<br>M src/mainboard/google/zoombini/variants/meowth/gpio.c<br>1 file changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/23195/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/zoombini/variants/meowth/gpio.c b/src/mainboard/google/zoombini/variants/meowth/gpio.c</span><br><span>index 39c2605..8ceb6e8 100644</span><br><span>--- a/src/mainboard/google/zoombini/variants/meowth/gpio.c</span><br><span>+++ b/src/mainboard/google/zoombini/variants/meowth/gpio.c</span><br><span>@@ -98,8 +98,8 @@</span><br><span>                              NF1), /* UART_PCH_TX_DEBUG_RX */</span><br><span> /* UART0_RTS# */ PAD_CFG_GPO(GPP_C10, 0, DEEP), /* PP3300_TOUCH_EN */</span><br><span> /* UART0_CTS# */        PAD_NC(GPP_C11, NONE),</span><br><span style="color: hsl(0, 100%, 40%);">-/* UART1_RXD */         PAD_CFG_GPI_APIC(GPP_C12, NONE, DEEP, EDGE_SINGLE,</span><br><span style="color: hsl(0, 100%, 40%);">-                                         INVERT), /* H1_PCH_INT_ODL */</span><br><span style="color: hsl(120, 100%, 40%);">+/* UART1_RXD */         PAD_CFG_GPI_SCI_LOW(GPP_C12, NONE, DEEP,</span><br><span style="color: hsl(120, 100%, 40%);">+                                          LEVEL), /* H1_PCH_INT_ODL */</span><br><span> /* UART1_TXD */             PAD_NC(GPP_C13, NONE),</span><br><span> /* UART1_RTS# */      PAD_CFG_GPI_SCI(GPP_C14, NONE, DEEP, EDGE_SINGLE,</span><br><span>                                    NONE), /* TOUCHSCREEN_INT_ODL */</span><br><span>@@ -265,9 +265,13 @@</span><br><span>                                 NF1), /* PCH_SPI_H1_3V3_MISO */</span><br><span> /* GSPI0_MOSI */  PAD_CFG_NF(GPP_B18, NONE, DEEP,</span><br><span>                                 NF1), /* PCH_SPI_H1_3V3_MOSI */</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+/* GSPI0_CS# */              PAD_NC(GPP_B15, NONE),</span><br><span style="color: hsl(120, 100%, 40%);">+/* GSPI0_CLK */         PAD_NC(GPP_B16, NONE),</span><br><span style="color: hsl(120, 100%, 40%);">+/* GSPI0_MISO */        PAD_NC(GPP_B17, NONE),</span><br><span style="color: hsl(120, 100%, 40%);">+/* GSPI0_MOSI */        PAD_NC(GPP_B18, NONE),</span><br><span> #endif</span><br><span style="color: hsl(0, 100%, 40%);">-/* UART1_RXD */         PAD_CFG_GPI_APIC(GPP_C12, NONE, DEEP, EDGE_SINGLE,</span><br><span style="color: hsl(0, 100%, 40%);">-                                       INVERT), /* H1_PCH_INT_ODL */</span><br><span style="color: hsl(120, 100%, 40%);">+/* UART1_RXD */         PAD_CFG_GPI_SCI_LOW(GPP_C12, NONE, DEEP, LEVEL),</span><br><span> };</span><br><span> </span><br><span> const struct pad_config *variant_gpio_table(size_t *num)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23195">change 23195</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23195"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ida1d1050db12982c3c497656162cc84c62a77f70 </div>
<div style="display:none"> Gerrit-Change-Number: 23195 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org> </div>