<p>Alex Thiessen has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23093">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/gitconfig: Don't require `remake`<br><br>As the code was moved from the Makefile.inc to a separate file,<br>`$(MAKE)` was replaced by `remake`, introducing dependency on this tool<br>which is basically a `make` with debugging capabilities.<br><br>Many developers don't have `remake` installed, leading to pre-commit<br>hooks being not executed properly. Apparently this was an<br>unintentional change in commit 9ab8ae6a (util/gitconfig: Make<br>gitconfig a bash script) and so it is reverted.<br><br>Change-Id: Ic5ee9a0770e173ef0ffacc773c7f30f38cf478e9<br>Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com><br>---<br>M util/gitconfig/gitconfig.sh<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/23093/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/gitconfig/gitconfig.sh b/util/gitconfig/gitconfig.sh</span><br><span>index 5f91a69..b80a2e9 100755</span><br><span>--- a/util/gitconfig/gitconfig.sh</span><br><span>+++ b/util/gitconfig/gitconfig.sh</span><br><span>@@ -7,7 +7,8 @@</span><br><span> for hook in commit-msg pre-commit ; do</span><br><span>     if [ util/gitconfig/$hook -nt .git/hooks/$hook ] || \</span><br><span>                [ ! -x .git/hooks/$hook ]; then</span><br><span style="color: hsl(0, 100%, 40%);">-         sed -e "s,%MAKE%,remake,g" util/gitconfig/$hook > .git/hooks/$hook</span><br><span style="color: hsl(120, 100%, 40%);">+               sed -e "s,%MAKE%,$(MAKE),g" util/gitconfig/$hook \</span><br><span style="color: hsl(120, 100%, 40%);">+                  > .git/hooks/$hook</span><br><span>                chmod +x .git/hooks/$hook</span><br><span>    fi</span><br><span> done</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23093">change 23093</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23093"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic5ee9a0770e173ef0ffacc773c7f30f38cf478e9 </div>
<div style="display:none"> Gerrit-Change-Number: 23093 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com> </div>