<p><a href="https://review.coreboot.org/23056">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23056/2/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_mainboard.asl">File src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_mainboard.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23056/2/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_mainboard.asl@18">Patch Set #2, Line 18:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/* Define two ports for CIO2 device where endpoint of port0<br> is connected to CAM0 and endpoint of port1 is connected to CAM1 */<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I imagine there is only one port and endpoint where only CAM0 is connected.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23056/2/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_mainboard.asl@25">Patch Set #2, Line 25:</a> <code style="font-family:monospace,monospace"> Package () { "port1", "PRT1" },</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">not needed, there is only one sensor.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23056/2/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/ipu_mainboard.asl@52">Patch Set #2, Line 52:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Name (PRT1, Package () {<br> ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),<br> Package () {<br> Package () { "port", 1 }, /* csi 1 */<br> },<br> ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),<br> Package () {<br> Package () { "endpoint0", "EP10" },<br> }<br> })<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we need this? Only one sensor on MIPI.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23056/2/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/mipi_camera.asl">File src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/mipi_camera.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23056/2/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/mipi_camera.asl@16">Patch Set #2, Line 16:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Scope (\_SB.PCI0.I2C2)<br>{<br> Device (PMIC)<br> {<br> Name (_HID, "INT3472") /* _HID: Hardware ID */<br> Name (_UID, Zero) /* _UID: Unique ID */<br> Name (_DDN, "TPS68470 PMIC") /* _DDN: DOS Device Name */<br> Name (CAMD, 0x64)<br><br> Method (_STA, 0, NotSerialized) /* _STA: Status */<br> {<br> Return (0x0F)<br> }<br><br> Method (PMON, 0, Serialized) {<br> /*<br> * Turn on 3V3_VDD. It takes around<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">There is a lot of code which is a copy of src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/mipi_camera.asl, specially the PMIC.<br>Can we utilize the common code from that file. Things may will turn murky. Feel free to split the original file.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23056/2/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/mipi_camera.asl@338">Patch Set #2, Line 338:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/* Increment only if VSIC < 4 */<br> If (LLess (VSIC, 4)) {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">For nautilus, this reference count will come down to 3 ideally (CAM0, VCM, NVM).<br>hmmmm...if we decide to split the common code then this value should also be configurable or derived from somewhere. Can't think of a right now.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23056">change 23056</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23056"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iebd41ac3631829bbb0b008761eb67c3db3e94638 </div>
<div style="display:none"> Gerrit-Change-Number: 23056 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Anonymous Coward #1001830 </div>
<div style="display:none"> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 02 Jan 2018 08:52:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>