<p>Gaggery Tsai <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://review.coreboot.org/23060">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Override KBL-U/R IccMax settings<br><br>According to Intel document #559100 KBL EDS v2.8, section 7.2<br>DC specifications, the IccMax setting for KBL-U, KBL-U42 and<br>Celeroni/Pentium are different. This patch overrides the IccMax<br>settings for KBL-U/R since device tree could not handle all<br>of them and it is inefficient to maintain the same code for all<br>variants. Hence, place it in the common code so that all variants<br>could leverage the benefits.<br><br>+----------------+-------------+---------------+-------+-------+<br>| Domain/Setting |  SA         |  IA           | GTUS  |  GTS  |<br>+----------------+-------------+---------------+-------+-------+<br>| IccMax         | 6A(U42)     | 64A(U42)      | 31A   | 31A   |<br>|                | 4.5A(Others)| 29A(Celeron)  | 31A   | 31A   |<br>|                |             | 32A(i3/i5)    | 31A   | 31A   |<br>+----------------+-------------+---------------+-------+-------+<br><br>BUG=b:71369428<br>BRANCH=None<br>TEST=emerge-fizz coreboot chromeos-bootimage & Ensure the KBL-U42,<br>     KBL-U and Celeron SKUs are identified correctly and IccMax settings<br>     are passed to FSPS correctly.<br><br>Change-Id: I291462b73d3fbd17f17975de7fd77dc48ca99251<br>Signed-off-by: Gaggery Tsai <gaggery.tsai@intel.com><br>---<br>M src/soc/intel/skylake/chip_fsp20.c<br>M src/soc/intel/skylake/include/soc/vr_config.h<br>M src/soc/intel/skylake/vr_config.c<br>3 files changed, 56 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/23060/2</pre><p>To view, visit <a href="https://review.coreboot.org/23060">change 23060</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23060"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: I291462b73d3fbd17f17975de7fd77dc48ca99251 </div>
<div style="display:none"> Gerrit-Change-Number: 23060 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Gaggery Tsai <gaggery.tsai@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kane Chen <kane.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>