<p>Thomas Weißschuh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23045">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Extract the VGA BIOS from an UEFI dump<br><br>Depends on the 3rd party Python library uefi-firmware-parser.<br>(https://github.com/theopolis/uefi-firmware-parser)<br><br>Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a<br>Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de><br>---<br>M src/arch/x86/Makefile.inc<br>M src/device/Kconfig<br>A util/vgabios_extract/vgabios_extract.py<br>3 files changed, 90 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/23045/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc</span><br><span>index cc227b3..3f2f1e4 100644</span><br><span>--- a/src/arch/x86/Makefile.inc</span><br><span>+++ b/src/arch/x86/Makefile.inc</span><br><span>@@ -38,9 +38,24 @@</span><br><span> $(NVRAMTOOL) -y $(top)/src/mainboard/$(MAINBOARDDIR)/cmos.layout -H $@</span><br><span> endif # CONFIG_HAVE_OPTION_TABLE</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+vgabios-rom=$(obj)/vgabios.rom</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ifeq ($(CONFIG_VGA_BIOS_EXTRACT),y)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+$(vgabios-rom): $(call strip_quotes,$(CONFIG_VGA_BIOS_EXTRACT_FILE))</span><br><span style="color: hsl(120, 100%, 40%);">+ @printf " VGA_BIOS_EXTRACT $(CONFIG_VGA_BIOS_EXTRACT_FILE) $(vgabios-rom)\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ util/vgabios_extract/vgabios_extract.py $(CONFIG_VGA_BIOS_EXTRACT_FILE) $(vgabios-rom)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+else</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+$(vgabios-rom): $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE))</span><br><span style="color: hsl(120, 100%, 40%);">+ $(CP) $(vgabios-rom) $(CONFIG_VGA_BIOS_FILE)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> stripped_vgabios_id = $(call strip_quotes,$(CONFIG_VGA_BIOS_ID))</span><br><span> cbfs-files-$(CONFIG_VGA_BIOS) += pci$(stripped_vgabios_id).rom</span><br><span style="color: hsl(0, 100%, 40%);">-pci$(stripped_vgabios_id).rom-file := $(call strip_quotes,$(CONFIG_VGA_BIOS_FILE))</span><br><span style="color: hsl(120, 100%, 40%);">+pci$(stripped_vgabios_id).rom-file := $(vgabios-rom)</span><br><span> pci$(stripped_vgabios_id).rom-type := optionrom</span><br><span> </span><br><span> cbfs-files-$(CONFIG_INTEL_MBI) += mbi.bin</span><br><span>diff --git a/src/device/Kconfig b/src/device/Kconfig</span><br><span>index 28298d5..a6b1168 100644</span><br><span>--- a/src/device/Kconfig</span><br><span>+++ b/src/device/Kconfig</span><br><span>@@ -566,11 +566,23 @@</span><br><span> like to add to your ROM.</span><br><span> </span><br><span> You will be able to specify the location and file name of the</span><br><span style="color: hsl(0, 100%, 40%);">- image later.</span><br><span style="color: hsl(120, 100%, 40%);">+ false</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config VGA_BIOS_EXTRACT</span><br><span style="color: hsl(120, 100%, 40%);">+ bool "Extract VGA BIOS from BIOS image"</span><br><span style="color: hsl(120, 100%, 40%);">+ depends on VGA_BIOS</span><br><span style="color: hsl(120, 100%, 40%);">+ default n</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+config VGA_BIOS_EXTRACT_FILE</span><br><span style="color: hsl(120, 100%, 40%);">+ string "VGA BIOS extract path and filename"</span><br><span style="color: hsl(120, 100%, 40%);">+ depends on VGA_BIOS_EXTRACT</span><br><span style="color: hsl(120, 100%, 40%);">+ default "3rdpart/blobs/mainboard/$(MAINBOARDDIR)/bios.bin"</span><br><span style="color: hsl(120, 100%, 40%);">+ help</span><br><span style="color: hsl(120, 100%, 40%);">+ The path and filename of the file to extract the VGA BIOS from.</span><br><span> </span><br><span> config VGA_BIOS_FILE</span><br><span> string "VGA BIOS path and filename"</span><br><span style="color: hsl(0, 100%, 40%);">- depends on VGA_BIOS</span><br><span style="color: hsl(120, 100%, 40%);">+ depends on VGA_BIOS && !VGA_BIOS_EXTRACT</span><br><span> default "vgabios.bin"</span><br><span> help</span><br><span> The path and filename of the file to use as VGA BIOS.</span><br><span>diff --git a/util/vgabios_extract/vgabios_extract.py b/util/vgabios_extract/vgabios_extract.py</span><br><span>new file mode 100755</span><br><span>index 0000000..1c32b93</span><br><span>--- /dev/null</span><br><span>+++ b/util/vgabios_extract/vgabios_extract.py</span><br><span>@@ -0,0 +1,60 @@</span><br><span style="color: hsl(120, 100%, 40%);">+#!/usr/bin/env python2</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+from __future__ import print_function</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+import uefi_firmware</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+def extract_vga_bios(blob):</span><br><span style="color: hsl(120, 100%, 40%);">+ volumes = uefi_firmware.search_firmware_volumes(blob)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ objects = []</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for v in volumes:</span><br><span style="color: hsl(120, 100%, 40%);">+ x = uefi_firmware.AutoParser(blob[v - 40:])</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if x.type() == 'unknown':</span><br><span style="color: hsl(120, 100%, 40%);">+ continue</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ objects.extend(x.parse().objects)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ while len(objects):</span><br><span style="color: hsl(120, 100%, 40%);">+ o = objects.pop()</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if not o:</span><br><span style="color: hsl(120, 100%, 40%);">+ continue</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ subobjects = filter(lambda x: x is not None, o.objects)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if subobjects:</span><br><span style="color: hsl(120, 100%, 40%);">+ objects.extend(subobjects)</span><br><span style="color: hsl(120, 100%, 40%);">+ continue</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if b'VGA Compatible BIOS' in o.content:</span><br><span style="color: hsl(120, 100%, 40%);">+ return o</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+if __name__ == '__main__':</span><br><span style="color: hsl(120, 100%, 40%);">+ import argparse</span><br><span style="color: hsl(120, 100%, 40%);">+ import sys</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ print(sys.argv)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ parser = argparse.ArgumentParser()</span><br><span style="color: hsl(120, 100%, 40%);">+ parser.add_argument('input', type=str)</span><br><span style="color: hsl(120, 100%, 40%);">+ parser.add_argument('output', type=str)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ args = parser.parse_args()</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ with open(args.input, 'rb') as f:</span><br><span style="color: hsl(120, 100%, 40%);">+ blob = f.read()</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ o = extract_vga_bios(blob)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if o is not None:</span><br><span style="color: hsl(120, 100%, 40%);">+ print('Found VGA Bios in {}'.format(o.guid_label), file=sys.stderr)</span><br><span style="color: hsl(120, 100%, 40%);">+ with open(args.output, 'wb') as f:</span><br><span style="color: hsl(120, 100%, 40%);">+ f.write(o.content)</span><br><span style="color: hsl(120, 100%, 40%);">+ else:</span><br><span style="color: hsl(120, 100%, 40%);">+ print('Did not find anything')</span><br><span style="color: hsl(120, 100%, 40%);">+ sys.exit(1)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23045">change 23045</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23045"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic95b7520c65062e2106f7bd7d39bb652d4cecd7a </div>
<div style="display:none"> Gerrit-Change-Number: 23045 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Thomas Weißschuh <thomas@t-8ch.de> </div>